From: Krzysztof Kozlowski <krzk@kernel.org>
To: Iker Pedrosa <ikerpedrosam@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: display: sitronix,st7920: Add DT schema
Date: Tue, 7 Oct 2025 18:12:44 +0900 [thread overview]
Message-ID: <bf207d35-3ca9-40a2-807a-0dbb0d1504de@kernel.org> (raw)
In-Reply-To: <20251006-st7920-v3-1-4f89d656fa03@gmail.com>
On 07/10/2025 02:48, Iker Pedrosa wrote:
> +
> +properties:
> + compatible:
> + const: sitronix,st7920
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 600000
> +
Datasheet I found on the web clearly stats you have at least VDD and XRESET.
Your binding is still not complete (and I asked...), while it should be
complete (See writing bindings doc).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-07 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 17:48 [PATCH v3 0/3] drm/sitronix/st7920: Add support for the ST7920 controller Iker Pedrosa
2025-10-06 17:48 ` [PATCH v3 1/3] dt-bindings: display: sitronix,st7920: Add DT schema Iker Pedrosa
2025-10-07 9:12 ` Krzysztof Kozlowski [this message]
2025-10-15 11:57 ` Iker Pedrosa
2025-10-06 17:48 ` [PATCH v3 2/3] drm: Add driver for Sitronix ST7920 LCD displays Iker Pedrosa
2025-10-07 9:48 ` Thomas Zimmermann
2025-10-06 17:48 ` [PATCH v3 3/3] MAINTAINERS: Add entry for Sitronix ST7920 driver Iker Pedrosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf207d35-3ca9-40a2-807a-0dbb0d1504de@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ikerpedrosam@gmail.com \
--cc=javierm@redhat.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox