From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D97D1DDA18 for ; Wed, 17 Dec 2025 21:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766006479; cv=none; b=pvN38JrzFWHeKtZmtpYRidoky437/o4AULsiQrbloZ7S7Y3I/XJt87BF+29Qmfe8I+RK/S5NhHCxEMsHR/kAcZIE41l5z4kv+KYTlLyRmlRt5D97QZ8XexUQbKFLp7WYKvH491QanDbTlDko4+smO9iUPUqChuN6EQLCeExfeEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766006479; c=relaxed/simple; bh=6DGQygBvVTJMFE6aDz2PZblYZ7MJgNtOX3N3Zd6UQMI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FJsS+uDbsDQQJA0f4MUjC7i1O7bnAId2K3eFq4lN5XTnaphgkgR/p2aU6zngHAE/iIdTKPH20JwJRDrPXdctCeAUUG5sGmdTbBBwJ6SWzNellTFjoVrZtps/Z5neqvCvTTx9VqIsL/0cQVU9tgZnG0wrSZPY8kpLJNBJNWVV6XI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HgPEDwAt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HgPEDwAt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66044C4CEFB; Wed, 17 Dec 2025 21:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766006479; bh=6DGQygBvVTJMFE6aDz2PZblYZ7MJgNtOX3N3Zd6UQMI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HgPEDwAtKy0TWGpmgh/b4cXMF8Y2ST7V7xIjfietrNQO4DdylqT0edRL4MP73Q+5O Mk4RVUCGOSsZAuHopbK/FCprtfAPAptLdAB1rqIshEwy4g2DN8dWmcmA/E6umEfWzX NqCmFc5cYjISuEXO9+Em4+s2eToyK3VGlcyqNxKZF4kRO/IGRg2Ocu9rdnCL82QPdU HWSXBk6dkq5wrU/R+5XpLsIWzcyJ/h02jbHnbCbjGAdIV2tko+ceyLDjKIZoYXLuLQ ARGFK5mOzgekZjF5zs1fxBGFWzqK4mtaHmXBpf93RKTPTEqQCnt+E7u0qAP3rJtIX6 cu4f9P695dfDQ== Message-ID: Date: Wed, 17 Dec 2025 15:21:17 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] x86/CPU/AMD: Output the AGESA version to the logs To: Yazen Ghannam Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jean Delvare , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org References: <20251216123354.9219-1-superm1@kernel.org> <20251216123354.9219-8-superm1@kernel.org> <20251217211844.GC1263950@yaz-khff2.amd.com> Content-Language: en-US From: Mario Limonciello In-Reply-To: <20251217211844.GC1263950@yaz-khff2.amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/17/25 3:18 PM, Yazen Ghannam wrote: > On Tue, Dec 16, 2025 at 06:33:54AM -0600, Mario Limonciello (AMD) wrote: >> On AMD Zen platforms that are running AGESA, there is sometimes >> DMI additional string for the AGESA version that can be helpful when >> debugging an issue. If this string is found output to kernel logs. >> >> Signed-off-by: Mario Limonciello (AMD) >> --- >> arch/x86/kernel/cpu/amd.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c >> index c19c4ee74dd1f..8f44439d3f993 100644 >> --- a/arch/x86/kernel/cpu/amd.c >> +++ b/arch/x86/kernel/cpu/amd.c >> @@ -1,6 +1,7 @@ >> // SPDX-License-Identifier: GPL-2.0-only >> #define pr_fmt(fmt) "x86/amd: " fmt >> >> +#include >> #include >> #include >> #include >> @@ -1406,3 +1407,20 @@ static __init int print_s5_reset_status_mmio(void) >> return 0; >> } >> late_initcall(print_s5_reset_status_mmio); >> + >> +#ifdef CONFIG_DMI >> +static __init int print_agesa_dmi_info(void) >> +{ >> + const struct dmi_device *dev = NULL; >> + >> + while ((dev = dmi_find_device(DMI_DEV_TYPE_ADDITIONAL, NULL, dev))) { >> + if (!strncmp(dev->name, "AGESA", 5)) { >> + pr_info("%s\n", dev->name); >> + break; >> + } >> + } >> + >> + return 0; >> +} >> +late_initcall(print_agesa_dmi_info); >> +#endif >> > > The Zen check is gone. Is that intentional? > No it's not, it's a good catch. We don't have an AGESA version in SMBIOS data on pre-zen hardware. I'll add in a check like we do for print_s5_reset_status_mmio() for the next spin. if (!cpu_feature_enabled(X86_FEATURE_ZEN)) return 0; > If so, then I think the commit message should be tweaked to not mention > Zen systems specifically. > > I don't think this is a problem. I think it's better to keep things > generic, if possible. > > Thanks, > Yazen