From: Bart Van Assche <bvanassche@acm.org>
To: Nitin Rawat <quic_nitirawa@quicinc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_cang@quicinc.com, Manish Pandey <quic_mapa@quicinc.com>
Subject: Re: [PATCH V4] scsi: ufs: core: store min and max clk freq from OPP table
Date: Wed, 6 Dec 2023 15:06:14 -1000 [thread overview]
Message-ID: <bf2b1671-2911-4d74-abfb-e6dbfe03d626@acm.org> (raw)
In-Reply-To: <20231206133812.21488-1-quic_nitirawa@quicinc.com>
On 12/6/23 03:38, Nitin Rawat wrote:
> + list_for_each_entry(clki, head, list) {
> + if (!clki->name)
> + continue;
> +
> + clki->clk = devm_clk_get(hba->dev, clki->name);
> + if (!IS_ERR(clki->clk)) {
Please change the above line into the following:
if (IS_ERR(...))
continue;
to reduce the indentation level of the code below this statement.
Thanks,
Bart.
prev parent reply other threads:[~2023-12-07 1:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 13:38 [PATCH V4] scsi: ufs: core: store min and max clk freq from OPP table Nitin Rawat
2023-12-06 13:47 ` Manivannan Sadhasivam
2023-12-07 1:06 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf2b1671-2911-4d74-abfb-e6dbfe03d626@acm.org \
--to=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=quic_mapa@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox