[PATCH v7 00/17] media: rkvdec: Add support for VDPU381 and VDPU383

Detlev Casanova
2025-12-18T23:28:36Z

These variants are found respectively in the RK3588 and RK3576 SoCs.
This patch only adds support for H264 and H265 in both variants.

As there is a considerable part of the code that can be shared with the
already supported rkvdec decoder driver, the support for these variants
is added here rather than writing a new driver.

This patch set uses the newly introduced hevc_ext_sps_[ls]t_rps v4l2
controls for HEVC.
Therefore, a patched version of userpace tools is needed for HEVC
support (added for GStreamer[1] and in an early stage for FFmpeg[2]).

The DTS changes can be found in another patch set: [3]

[1]: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9355
[2]: https://gitlab.collabora.com/detlev/ffmpeg
[3]: https://lore.kernel.org/all/20251020212009.8852-1-detlev.casanova@collabora.com/

Changes since v6:
- Remove coded_fmts capabilities
- Remove inexistant V4L2_HEVC kconfig dependency
- Add missing rkvdec registers
- Fix memcpy sizes
- Remove non-necessary name and style changes
- Use common get_image_fmt
- Do not validate sps in start()
- Remove unused variable
- Change named_regs to has_single_reg_region
- Compared to v6, I didn't use a union for the ref addr and flags
registers, as I find the flat struct more readable.

Changes since v5:
- Extract multicore management in separate commit
- Move variant specific functions to an ops struct
- Fix a typo and "h264" -> "hevc" copy/paste mistakes
- Move RKVDEC_*_PIXELS to rkvdec.h
- Drop VDPU383_*_PIXELS, use the the RKVDEC ones instead
- Change RKVDEC_1080P_PIXELS value to 1920 * 1088
- Long and short term ref sets extend controls:
- Add them in visl traces
- Reword documentation to specify SPS extension and use
- Mention Vulkan Video API similarity
- Specify behavior for empty array values
- Reorder struct fields to ensure fixed compiled size
- Remove the mention of V4L2_CTRL_FLAG_DYNAMIC_ARRAY flag

Changes since v4:
- Add basic ext_sps_[ls]t_rps validation (flags only)
- Add missing copyright in new common files
- Rename num_coded_fmts, rcb_num, clk_count
- Avoid allocating RCB config when not needed
- Merge rkvdec_config into rkvdec_variant
- Keep rkvdec_hevc_get_image_fmt per variant

Changes since v3:
- Rebased on latest next (ea299a216426) + HEVC support for rk3399

Changes since v2:
- Rebased on Kwiboo's HEVC support for rk3399
- Include hevc_ext_sps_[ls]t_rps v4l2 controls commits
- Remove empty lines at end of files
- Rename RKVDEC2_ALLOC_* to RKVDEC_ALLOC_*
- Set min_with and min_height to 64
- Remove vdpu38x_fill_pixfmt_mp() function
- Handle userspace not supporting hevc_ext_sps_[ls]t_rps
- Make all config structs static const

Changes since v1:
- Add parsing of the short and long term ref frame sets from the new v4l2
controls
- Add RPS cache to avoid parsing the same data again
- Fix HEVC pixel formats selection
- Fix multiple indentation errors

Detlev Casanova (17):
media: uapi: HEVC: Add v4l2_ctrl_hevc_ext_sps_[ls]t_rps controls
media: v4l2-ctrls: Add hevc_ext_sps_[ls]t_rps controls
media: visl: Add HEVC short and long term RPS sets
media: rkvdec: Switch to using structs instead of writel
media: rkvdec: Move cabac tables to their own source file
media: rkvdec: Use structs to represent the HW RPS
media: rkvdec: Move h264 functions to common file
media: rkvdec: Move hevc functions to common file
media: rkvdec: Add variant specific coded formats list
media: rkvdec: Add RCB and SRAM support
media: rkvdec: Support per-variant interrupt handler
media: rkvdec: Enable all clocks without naming them
media: rkvdec: Disable multicore support
media: rkvdec: Add H264 support for the VDPU381 variant
media: rkvdec: Add H264 support for the VDPU383 variant
media: rkvdec: Add HEVC support for the VDPU381 variant
media: rkvdec: Add HEVC support for the VDPU383 variant

.../media/v4l/ext-ctrls-codec-stateless.rst | 120 +++
.../media/v4l/videodev2.h.rst.exceptions | 2 +
.../media/v4l/vidioc-queryctrl.rst | 12 +
.../media/platform/rockchip/rkvdec/Makefile | 14 +-
.../{rkvdec-hevc-data.c => rkvdec-cabac.c} | 506 +++++++++-
.../rockchip/rkvdec/rkvdec-h264-common.c | 258 +++++
.../rockchip/rkvdec/rkvdec-h264-common.h | 89 ++
.../platform/rockchip/rkvdec/rkvdec-h264.c | 892 ++----------------
.../rockchip/rkvdec/rkvdec-hevc-common.c | 512 ++++++++++
.../rockchip/rkvdec/rkvdec-hevc-common.h | 109 +++
.../platform/rockchip/rkvdec/rkvdec-hevc.c | 281 +-----
.../platform/rockchip/rkvdec/rkvdec-rcb.c | 179 ++++
.../platform/rockchip/rkvdec/rkvdec-rcb.h | 29 +
.../platform/rockchip/rkvdec/rkvdec-regs.h | 586 ++++++++----
.../rockchip/rkvdec/rkvdec-vdpu381-h264.c | 465 +++++++++
.../rockchip/rkvdec/rkvdec-vdpu381-hevc.c | 621 ++++++++++++
.../rockchip/rkvdec/rkvdec-vdpu381-regs.h | 424 +++++++++
.../rockchip/rkvdec/rkvdec-vdpu383-h264.c | 578 ++++++++++++
.../rockchip/rkvdec/rkvdec-vdpu383-hevc.c | 720 ++++++++++++++
.../rockchip/rkvdec/rkvdec-vdpu383-regs.h | 281 ++++++
.../platform/rockchip/rkvdec/rkvdec-vp9.c | 232 ++---
.../media/platform/rockchip/rkvdec/rkvdec.c | 572 +++++++++--
.../media/platform/rockchip/rkvdec/rkvdec.h | 49 +-
drivers/media/test-drivers/visl/visl-dec.c | 7 +
drivers/media/test-drivers/visl/visl-dec.h | 3 +
.../media/test-drivers/visl/visl-trace-hevc.h | 59 ++
drivers/media/v4l2-core/v4l2-ctrls-core.c | 28 +
drivers/media/v4l2-core/v4l2-ctrls-defs.c | 10 +
include/uapi/linux/v4l2-controls.h | 61 ++
include/uapi/linux/videodev2.h | 2 +
30 files changed, 6238 insertions(+), 1463 deletions(-)
rename drivers/media/platform/rockchip/rkvdec/{rkvdec-hevc-data.c => rkvdec-cabac.c} (86%)
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-h264-common.c
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-h264-common.h
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-hevc-common.c
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-hevc-common.h
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-rcb.c
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-rcb.h
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-h264.c
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-hevc.c
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu381-regs.h
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-h264.c
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-hevc.c
create mode 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-regs.h

--
2.52.0