From: Binbin Wu <binbin.wu@linux.intel.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Shuah Khan <shuah@kernel.org>,
"Chang S. Bae" <chang.seok.bae@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Weihong Zhang <weihong.zhang@intel.com>,
angquan yu <angquan21@gmail.com>,
kernel@collabora.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: x86: skip the tests if prerequisites aren't fulfilled
Date: Tue, 12 Mar 2024 08:10:14 +0800 [thread overview]
Message-ID: <bf4cb384-97ce-4782-b6b9-e75780cdf167@linux.intel.com> (raw)
In-Reply-To: <20240307183730.2858264-1-usama.anjum@collabora.com>
On 3/8/2024 2:37 AM, Muhammad Usama Anjum wrote:
> diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/lam.c
> index 215b8150b7cca..c0f016f45ee17 100644
> --- a/tools/testing/selftests/x86/lam.c
> +++ b/tools/testing/selftests/x86/lam.c
> @@ -1183,7 +1183,7 @@ int main(int argc, char **argv)
>
> if (!cpu_has_lam()) {
> ksft_print_msg("Unsupported LAM feature!\n");
> - return -1;
> + return KSFT_SKIP;
> }
>
> while ((c = getopt(argc, argv, "ht:")) != -1) {
Looks good to me.
Reviewed-by: Binbin Wu <binbin.wu@linux.intel.com>
prev parent reply other threads:[~2024-03-12 0:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 18:37 [PATCH] selftests: x86: skip the tests if prerequisites aren't fulfilled Muhammad Usama Anjum
2024-03-09 1:06 ` Chang S. Bae
2024-03-11 17:02 ` Muhammad Usama Anjum
2024-03-11 17:39 ` Chang S. Bae
2024-03-12 9:26 ` Muhammad Usama Anjum
2024-03-12 16:07 ` Chang S. Bae
2024-03-12 17:28 ` Muhammad Usama Anjum
2024-03-11 12:39 ` Kirill A. Shutemov
2024-03-12 0:10 ` Binbin Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf4cb384-97ce-4782-b6b9-e75780cdf167@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=angquan21@gmail.com \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
--cc=weihong.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox