From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FDA7A928; Tue, 12 Mar 2024 00:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710202223; cv=none; b=IBDoI+VdR+lGP1jS4Crc+YTSD1fjx8Tpzf1VFvYTD8VTHH3IYJEMflZABVcBrfviagtS4sUqsD84GgSsBY4ziGd1sWsY8SvE6hNV78HYzK7pX7sFqUHfuaJJPgQeRJ4GzahQ+lbAaHPZl+1p5uLYLMctqKVkx1uPf1QFoJobke4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710202223; c=relaxed/simple; bh=pPkeMy7fBltTdNYOZZoPxSZoY5kmxQRciVH9Q0F3/DI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gmIxdLMQkuOJwWZ0kOefcAamkApeji6EOy52mNdpc9P3sG6iuqOOUYttL17fB1bNpCHrskFHqidBsNYBfmQQIHZYT/nFFML8Br0HgKc7LwQ2D3c4Fwi2nCSiAJmsQS0W6P2q0YAJKwWCGZQOcKYXzyEy/i7gEjYw2l2V4dcsz+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QptglPgs; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QptglPgs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710202222; x=1741738222; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=pPkeMy7fBltTdNYOZZoPxSZoY5kmxQRciVH9Q0F3/DI=; b=QptglPgsyZ4kpZ4sDJYpjFv2H0Kgnl6yyYGJeol1LIoiwGPRL2FYSOKZ lplEt5Zqs4GZSKzCYtqptuIW8NMm4ekIrbxm0c9JDayNvgYmvz+27B+SM DagBbuMBet1dzLKkGMbh+0PaO7XonTRzFsx9uKZJRE5bOHF3DxU6MKBtg hOqKrIPBdjF13ahC+rSFmDkgVvrevAo7nfldNINuDFVDI8cyLByQOtf19 46036+tSEhulFVX8TG1bAPHZwz3uFP2KweBGdTDD1oYKM7qssXe4zBM3k xkDM/ZmOgo2oPm53Y4twvVyopKVP0E/jXeLm9r8CSsMwtQ4snP4lgujGs Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11010"; a="22409287" X-IronPort-AV: E=Sophos;i="6.07,117,1708416000"; d="scan'208";a="22409287" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 17:10:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,117,1708416000"; d="scan'208";a="48797633" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.125.242.247]) ([10.125.242.247]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 17:10:17 -0700 Message-ID: Date: Tue, 12 Mar 2024 08:10:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: x86: skip the tests if prerequisites aren't fulfilled To: Muhammad Usama Anjum Cc: Shuah Khan , "Chang S. Bae" , Dave Hansen , "Kirill A. Shutemov" , "Peter Zijlstra (Intel)" , Weihong Zhang , angquan yu , kernel@collabora.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240307183730.2858264-1-usama.anjum@collabora.com> From: Binbin Wu In-Reply-To: <20240307183730.2858264-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/8/2024 2:37 AM, Muhammad Usama Anjum wrote: > diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/lam.c > index 215b8150b7cca..c0f016f45ee17 100644 > --- a/tools/testing/selftests/x86/lam.c > +++ b/tools/testing/selftests/x86/lam.c > @@ -1183,7 +1183,7 @@ int main(int argc, char **argv) > > if (!cpu_has_lam()) { > ksft_print_msg("Unsupported LAM feature!\n"); > - return -1; > + return KSFT_SKIP; > } > > while ((c = getopt(argc, argv, "ht:")) != -1) { Looks good to me. Reviewed-by: Binbin Wu