From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
Yunsheng Lin <linyunsheng@huawei.com>,
Alexander Duyck <alexanderduyck@fb.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
Simon Horman <simon.horman@corigine.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 0/6] page_pool: a couple of assorted optimizations
Date: Fri, 4 Aug 2023 16:31:05 +0200 [thread overview]
Message-ID: <bf553c4a-2f31-9a92-77e9-7670b062e768@intel.com> (raw)
In-Reply-To: <20230803182121.1baf4c13@kernel.org>
From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 3 Aug 2023 18:21:21 -0700
> On Thu, 3 Aug 2023 20:20:32 +0200 Alexander Lobakin wrote:
>> That initially was a spin-off of the IAVF PP series[0], but has grown
>> (and shrunk) since then a bunch. In fact, it consists of three
>> semi-independent blocks:
>>
>> * #1-2: Compile-time optimization. Split page_pool.h into 2 headers to
>> not overbloat the consumers not needing complex inline helpers and
>> then stop including it in skbuff.h at all. The first patch is also
>> prereq for the whole series.
>> * #3: Improve cacheline locality for users of the Page Pool frag API.
>> * #4-6: Use direct cache recycling more aggressively, when it is safe
>> obviously. In addition, make sure nobody wants to use Page Pool API
>> with disabled interrupts.
>>
>> Patches #1 and #5 are authored by Yunsheng and Jakub respectively, with
>> small modifications from my side as per ML discussions.
>> For the perf numbers for #3-6, please see individual commit messages.
>
> Our scheming didn't help much, the series also conflicts
> with the net/xdp.h includes which came in via bpf-next :(
Haha that happens. I rechecked everything before sending, but well, we
need a spinlock or what :D
I'll send v4 in a couple hours, so that ~22 hrs will pass since v3,
sounds okay?
Thanks,
Olek
prev parent reply other threads:[~2023-08-04 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 18:20 [PATCH net-next v3 0/6] page_pool: a couple of assorted optimizations Alexander Lobakin
2023-08-03 18:20 ` [PATCH net-next v3 1/6] page_pool: split types and declarations from page_pool.h Alexander Lobakin
2023-08-03 18:20 ` [PATCH net-next v3 2/6] net: skbuff: don't include <net/page_pool/types.h> to <linux/skbuff.h> Alexander Lobakin
2023-08-03 18:20 ` [PATCH net-next v3 3/6] page_pool: place frag_* fields in one cacheline Alexander Lobakin
2023-08-03 18:20 ` [PATCH net-next v3 4/6] net: skbuff: avoid accessing page_pool if !napi_safe when returning page Alexander Lobakin
2023-08-03 18:20 ` [PATCH net-next v3 5/6] page_pool: add a lockdep check for recycling in hardirq Alexander Lobakin
2023-08-04 10:30 ` Jesper Dangaard Brouer
2023-08-03 18:20 ` [PATCH net-next v3 6/6] net: skbuff: always try to recycle PP pages directly when in softirq Alexander Lobakin
2023-08-04 1:21 ` [PATCH net-next v3 0/6] page_pool: a couple of assorted optimizations Jakub Kicinski
2023-08-04 14:31 ` Alexander Lobakin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf553c4a-2f31-9a92-77e9-7670b062e768@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox