Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB

["Andreas Färber" <afaerber@suse.de>]

Hi James,

Am 04.02.20 um 15:52 schrieb James Tai:
> Define compatible strings for Realtek RTD1319 SoC and Realtek PymParticle
> EVB.
> 
> Signed-off-by: James Tai <james.tai@realtek.com>
> ---
>   v2 -> v3: Unchanged
> 
>   v1 -> v2:
>   * Put string in alphabetical order
> 
>   Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
> index 845f9c76d6f7..3b48ae71fdd8 100644
> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> @@ -42,6 +42,12 @@ properties:
>                 - synology,ds418 # Synology DiskStation DS418
>             - const: realtek,rtd1296
>   
> +      # RTD1319 SoC based boards
> +      - items:
> +          - enum:
> +              - realtek,pymparticle # Realtek PymParticle EVB

The board seems labelled "PYM_PARTICLES".

While Wikipedia has nothing on that, I found this explanation:
https://marvel.fandom.com/wiki/Pym_Particles

So, are you sure it's PymParticle and not "Pym Particle" with space or 
"Pym Particles" with space and plural S? The S would affect also the 
.dts filename. For the compatible string the question is pymparticle or 
pym-particle.

By comparison, LION-SKIN was named lion-skin in the compatible and 
spelled Lion Skin in textual form. If you believe that should be fixed, 
now would be the time to revisit those patches that didn't make v5.7.

Thanks,
Andreas

> +          - const: realtek,rtd1319
> +
>         # RTD1395 SoC based boards
>         - items:
>             - enum:

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)