From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2A42145FE0 for ; Thu, 16 May 2024 15:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715874907; cv=none; b=b9Ky/u2B38LSGJejJ4lSlU9WCi5z581WEyB5xQ6bUpvv+Qws7zw6VhjSY1FNueIIwP6u6JzfjFvPnh9ufuCnrsG4ByaDpJuCtj4MReIFf5D32w4MrCUDfhpkSGEP9WVL8N+APi0p6W65QfMjbt85J+HvJdX2dwCdLfHj4lkmh0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715874907; c=relaxed/simple; bh=nN00p+BB6G3oXDgct+EBmEwHz4fIJMGD6RriYL6RGhY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZP5yAL/tWQ9uQkwUg9LbJQnG48CjNABu1J+LWvP5irWBVBYzzsxqJ/XFlZ3eWAk3fCn19qKI9czCT4pgbyJHizDpQhEpXiaoImnr4PF+5BFsNPYzXRBKHVq2RMkS16chiwKZ5YXl3Ub1rAHh+xSBWf9bGAw75heDJBldEWHA36I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=g2MMtuiR; arc=none smtp.client-ip=209.85.166.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="g2MMtuiR" Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7e195fd1d8eso6553039f.0 for ; Thu, 16 May 2024 08:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1715874905; x=1716479705; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ab4/9SXReNXDQjfL5I+PFsnXsCfrtKWnsASearG9QQU=; b=g2MMtuiRfR8eHXbLO01GoAyMEOgBmWwpF20hCztLiCp2zPTkPtmpSjvaUsPZUBsfaA BGotKNuX3/E07EZ4cDdg2Fb8ZTArNUIS2XHGHS0OgLdveMuodH/vKu9T6QCsARjYGgDE MLB5r4wc2CdpXcSXJQ0+NxE+SkJjRejGqo1fo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715874905; x=1716479705; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ab4/9SXReNXDQjfL5I+PFsnXsCfrtKWnsASearG9QQU=; b=GgucPcfKGCeWzXSzIrBlXHRXBc6mwOgmhbVqjcqrUEMCb6EkVZcs1LRzwIQ6y/Nm7h FlCn3R4ietcBokJBkTHL9zvYqsSBvBj5VtxWkVScQaEaV6ywnK3VoYwZkgyttpbsETa4 SLseHWWoLgU+5Sl3m+aJDFEvmju3IVDepW6YmnvABqZkGWijMDLGnahC+sP67NJ0zDQD rfMa+o36ZsWr4ubn6DBHFHm2h04D3NKqNeHiz37cvlv7QCDytulPZq4rftKb4Fc9Onqg h9st9hwa9wFxkjAap3ppdYLDgpO8CZgsLjvP4TKncsQqoZ8sGXFFKTISYKS9k17df774 JtJA== X-Gm-Message-State: AOJu0YxN9l9HJimzZJ0zOBaYP5pk08eGWDVBSR28KGOAut3VX6RyFkjW La4mZsQMigFLjwv/zHpshPOt67K4wJfkw0S81a44ssw63B0KAlm85CAXjJP4nDY= X-Google-Smtp-Source: AGHT+IFkrQ63gFwV/5y3qWi0SsRylHli+g/GXjCSjbCIbAnwmlot3x2PILn1QDwIRhTHEUwb7pHpvA== X-Received: by 2002:a6b:d203:0:b0:7e1:8bc8:8228 with SMTP id ca18e2360f4ac-7e1b501f23dmr1984498939f.0.1715874905028; Thu, 16 May 2024 08:55:05 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-7e20378a041sm127028439f.26.2024.05.16.08.55.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 May 2024 08:55:04 -0700 (PDT) Message-ID: Date: Thu, 16 May 2024 09:55:03 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 00/66] Define _GNU_SOURCE for sources using To: Edward Liaw , shuah@kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, Shuah Khan References: <20240510000842.410729-1-edliaw@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240510000842.410729-1-edliaw@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/9/24 18:06, Edward Liaw wrote: > Centralizes the definition of _GNU_SOURCE into KHDR_INCLUDES and removes > redefinitions of _GNU_SOURCE from source code. > > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > asprintf into kselftest_harness.h, which is a GNU extension and needs > _GNU_SOURCE to either be defined prior to including headers or with the > -D_GNU_SOURCE flag passed to the compiler. > > v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/ > v2: https://lore.kernel.org/linux-kselftest/20240507214254.2787305-1-edliaw@google.com/ > - Add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single > location. > - Remove #define _GNU_SOURCE from source code to resolve redefinition > warnings. > v3: https://lore.kernel.org/linux-kselftest/20240509200022.253089-1-edliaw@google.com/ > - Rebase onto linux-next 20240508. > - Split patches by directory. > - Add -D_GNU_SOURCE directly to CFLAGS in lib.mk. > - Delete additional _GNU_SOURCE definitions from source code in > linux-next. > - Delete additional -D_GNU_SOURCE flags from Makefiles. > v4: > - Rebase onto linux-next 20240509. > - Remove Fixes tag from patches that drop _GNU_SOURCE definition. > - Restore space between comment and includes for selftests/damon. > > Edward Liaw (66): > selftests: Compile with -D_GNU_SOURCE when including lib.mk This above change is causing some build problems - I didn't notice them when I tested on linux-next. However some problems are seen by Mark. He sent in a fix for ALSA and a change to descalate build warn. Please don't apply these for 6.10 for now. I will take all of these together. thanks, -- Shuah