public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: vgarodia@codeaurora.org
To: Mansur Alisha Shaik <mansur@codeaurora.org>
Cc: linux-media@vger.kernel.org, stanimir.varbanov@linaro.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [RESEND] venus: fix calculating mbps in calculate_inst_freq()
Date: Mon, 02 Nov 2020 21:09:15 +0530	[thread overview]
Message-ID: <bf8acb0c470207289a09f63d829dfb08@codeaurora.org> (raw)
In-Reply-To: <1604313097-2178-1-git-send-email-mansur@codeaurora.org>

Hi Mansur,

On 2020-11-02 16:01, Mansur Alisha Shaik wrote:
> Currently in calculate_inst_freq(), video driver is calculating
> macro blocks per frame in stead of macro blocks per second(mpbs).
instead

> Which results frequency is always setting to lower frequency (150MB)
> as per frequency table for sc7180. Hence the playback is not smooth.
150MHz

> 
> Corrected this by correcting the mbps calculation in 
> calculate_inst_freq().
> 
> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
> ---
>  drivers/media/platform/qcom/venus/pm_helpers.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c
> b/drivers/media/platform/qcom/venus/pm_helpers.c
> index 57877ea..001513f 100644
> --- a/drivers/media/platform/qcom/venus/pm_helpers.c
> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c
> @@ -928,7 +928,7 @@ static unsigned long calculate_inst_freq(struct
> venus_inst *inst,
>  	u32 fps = (u32)inst->fps;
>  	u32 mbs_per_sec;
> 
> -	mbs_per_sec = load_per_instance(inst) / fps;
> +	mbs_per_sec = load_per_instance(inst);

Good find.

Thanks,
Vikash

      reply	other threads:[~2020-11-02 15:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 10:31 [RESEND] venus: fix calculating mbps in calculate_inst_freq() Mansur Alisha Shaik
2020-11-02 15:39 ` vgarodia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf8acb0c470207289a09f63d829dfb08@codeaurora.org \
    --to=vgarodia@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mansur@codeaurora.org \
    --cc=stanimir.varbanov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox