From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64C7231B127 for ; Wed, 7 Jan 2026 14:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767794630; cv=none; b=Z8k/ICF5hNhzViwXhHUzJelUGAwWsWh/8q7wRww4sBNVo1NefwafUQKWrodruDdapf787bKWFmcE6bd7YhwJvDhNFr3BLXWmIwTtjvsPnitDh7ZVrvmkEApGOXCUK/MNomv/kjjLxt0uBk+bTYImppLdBP4XGaUMPapxp/NkFxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767794630; c=relaxed/simple; bh=+eBgn1FXDfynTOWRPQJQcXgChNeUrZJfwmqaclXZWmg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J4lBIP4q+rEfbzOlJ2gOZG9c6ORvnqMYRIaaywWa8WGQ0A3FoluZpayQEng6+6BbYct+8HlDgAjhx6qm0noED+9VHVs51J+9hi+YFlvLcA0/UIJtDhct+NbB+Q7WH3sNowHnurQhIN+im2UVSItvnTpElSMnum4A3rl+eqJHsAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iSNboE4c; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BeQCoNn8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iSNboE4c"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BeQCoNn8" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6079q9aO218515 for ; Wed, 7 Jan 2026 14:03:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZGUEfPXYzSComK/4z89HH9yCe+htm7JQCogZL+pmhcU=; b=iSNboE4cXnSfjv6Q T9IeoddUr7lZJW8JimTlQkX8C++dWLYVbrQ3iI8zPng6hDQm7HKgCdwBej/yd8UP DdT4+bAvoTp3Jj+n+IElHDSqe2QA9boZVBngHYuDdp15iYidSpx59EPsmBOpwjmD L4eEBIWgi4TPqLnRfUqZyphcvWM85J/1bkwbon5pN2YoSeZvpFF3ocYNh5Clos7i Y/+ckUU78QqaWvGIjZSSUtWe5olAFd96RWRQZ5/tqdDRPVW2OT0nz8x0oumcz1To 4dzl9vRKocCBRkcKmeHZxmvdS236A4GGd8wjXQElzTrQ29gcf/RDtEqWNXTzXpNI DMkEdQ== Received: from mail-yx1-f69.google.com (mail-yx1-f69.google.com [74.125.224.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bhn808pnw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 07 Jan 2026 14:03:44 +0000 (GMT) Received: by mail-yx1-f69.google.com with SMTP id 956f58d0204a3-64565434d7fso462912d50.0 for ; Wed, 07 Jan 2026 06:03:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767794622; x=1768399422; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZGUEfPXYzSComK/4z89HH9yCe+htm7JQCogZL+pmhcU=; b=BeQCoNn85dpOdRPpdu5Kj/HNnppYqNZ8jbVakwqbyxUaxNAqs/8Z9fAjHytgcl/y4B XIVpVvoodBQKXxIIeUh1g4oucWKDGP8tOexD3+VdbiAPZiMpQiv98Pp5AZhgtnqhEV3C fBlqMT05KIzxboZ11feNiz9IPFc4baUMeA94yX/XCMSWnER4SUI0qq4J4pPtQaPE4Mlu 4oLVldvV3jA9Y0neTV1DMogS31G/DyaIdC/jEfh1sc5d7gK0rDcCa1QkmXLo5WjP3ich HhlxfAqJwv6eaiVZ0rer8jxMMn9xm11Lx7hvEP/ETZAPPepGaDiXiNxJWk8EwtBcIci3 fedQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767794622; x=1768399422; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZGUEfPXYzSComK/4z89HH9yCe+htm7JQCogZL+pmhcU=; b=lBv9P0pgzOr9O4DoG/y+Z/p1mFJALt8lRBK+OV5WzjUI3QVzgru+VW/kkf8UM9t7Vv Y79STWttKTYOmJDDV4NaoTZyFn+suuTYCgOsIiDRNUViVJ+n6SFOGsxGQofxXvbzmKjo sQNh1zeLgdD72AKtECWwA1cYdBa0uPzWzotFt5jOp70at4RlWsnaP+Sl1DjpxBwjK8F1 zL5w/a4wvL5tOKZU45MLqO4yemsdlcvAGXqy8RfYA9TBkaKi7eEKtSTjB0VwQXcU/Ij+ z54Mw3LcwVtCxW36AOXEm6db9cl+wChwIfZYVdyv+HczHzBOOmkj7zFAmOT6UCxaVUWg dm4g== X-Forwarded-Encrypted: i=1; AJvYcCUi5FDsMbWxkYQ9w7HsaIPsVCz6pUahHjozdovYnuz++S1dgK/c9Hxrf6Iq+/FPHUwlCEAKR4GWfAkRBUI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/VO0J7iQlVjmiq7de+3kY3rFF6X1ejjlwF5WjEJdvSC2K+DlG GBIZeZUpW42iw87EOVPJlYhvjXHFuynGq84sz4iOxkPsb+NKrPYCTqV4Ul0c68gOqqYRT2h6Kyp 3jeFM8AbV31mbINnj53nOQDqImQPXInZQOHBLvQHYCXWltXhpdM3wLC8WE/ys479p6JA= X-Gm-Gg: AY/fxX4WQrOfokx0F4hNl+QyKP6k3MKAyf0NzuS/GqRVG9cAtlVvF0Dof6sZLYDx3rM bTSMvcYQSYKYcHjTcW0uXafpOL7IoQBUWdEF0AeKyxk2s6HhojHElkzgkhW5CjISy6P9isnwfbu wnDM++/53KKa+uQO+813i9UKtWBUGLstM0VYuVoqK8+DhhCgBClzVRQEPPTARPPvt9o1yk6lAoP mPlG77gTeA/XfjWiJ61norQ4HaeS68EwgVvwXwVKGc4SetUMIrieY8AnMdwMEcZ4S/mC77jPaMf fj826tx9Ym+O7YGm4rx6c+sWSmRFZ0rq//GDDhejM6qgYatb42uhbwZSxPLvrtH9cNg3X1rDr6p 4TlDlYrKY5d0BMNXmgafxpfhQjr+vSWyZvtC6a5VDj6IGxGsILI9nWiibq1s6cn1+VV8= X-Received: by 2002:a05:690e:1486:b0:646:5127:ad64 with SMTP id 956f58d0204a3-64716c9291fmr1920171d50.8.1767794622195; Wed, 07 Jan 2026 06:03:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+yD6IwhCJBS0M0IdpMAihYXZ2W52QH5LWTaJGmcGDkAkN6V6xxs4QcaIu2Pf8pk26NxzbQA== X-Received: by 2002:a05:690e:1486:b0:646:5127:ad64 with SMTP id 956f58d0204a3-64716c9291fmr1920088d50.8.1767794620266; Wed, 07 Jan 2026 06:03:40 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507b9d4c89sm4571078a12.10.2026.01.07.06.03.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 06:03:39 -0800 (PST) Message-ID: Date: Wed, 7 Jan 2026 15:03:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8950 To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Kiran Gunda , Helge Deller , Luca Weiss , Konrad Dybcio , Eugene Lepshy , Gianluca Boiano , Alejandro Tafalla Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Thompson , linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org References: <20260107-pmi8950-wled-v1-0-5e52f5caa39c@mainlining.org> <20260107-pmi8950-wled-v1-1-5e52f5caa39c@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260107-pmi8950-wled-v1-1-5e52f5caa39c@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=OtJCCi/t c=1 sm=1 tr=0 ts=695e67c0 cx=c_pps a=J+5FMm3BkXb42VdG8aMU9w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=OuZLqq7tAAAA:8 a=EUspDBNiAAAA:8 a=WZtaUWDQifwC2z0g4SgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=Epx66wHExT0cjJnnR-oj:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-GUID: n7vY47VdremvUipf4N7xvwtqEkby0EM1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA3MDEwOCBTYWx0ZWRfXyP7H9tpJjp/9 bUtxAnZqx9z37gixW9B+5kMATE/Ql3+7BVgLkRUPr0HRF8ZSuGVN4z2KNGDOTRRheyUF8uo/ugA ORkW8+TlkZQ6DCX7SnbdTOqOw580pKjOM3fpA8XLdv7Z8+6leu1P2teQpohx6vzQEcGiMtTFrRY CknSWbbNWbR5ga8BIhOstA+bLe2m7cz/CsabCP9r63Vmm98nTn1IwdsNmzEbOWb62bPyGf3yPSf jKD4SauEIECgmY7K+LgzZ8kWiNj0q5EfVsTndzaC+GfUIAvGM3A4scswMb33s/2UM1IxpE2TUPO hgL/oQbV/ZV1iKTB+Hbsf+n6js9Y0yr0EVlgWpsrqEK32wh4IZ72WaQDu2MZEDncmQh9sVqW0lH qEC4m3Dem5xGItsFV4HpoOT8qdmb9qXWjBm1IbLbyMBPsL3xJf7sCciZf9E6duw5DyBqoOkFVzh 6/3dk5ijpR2SagKbgBg== X-Proofpoint-ORIG-GUID: n7vY47VdremvUipf4N7xvwtqEkby0EM1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-07_02,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 malwarescore=0 priorityscore=1501 adultscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601070108 On 1/7/26 2:31 PM, Barnabás Czémán wrote: > Document ovp values supported by wled found in PMI8950. > > Signed-off-by: Barnabás Czémán > --- > .../bindings/leds/backlight/qcom-wled.yaml | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > index a8490781011d..306fb6642617 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > @@ -98,8 +98,6 @@ properties: > description: | > Over-voltage protection limit. This property is for WLED4 only. > $ref: /schemas/types.yaml#/definitions/uint32 > - enum: [ 18100, 19600, 29600, 31100 ] > - default: 29600 > > qcom,num-strings: > description: | > @@ -239,6 +237,24 @@ allOf: > minimum: 0 > maximum: 4095 > > + - if: > + properties: > + compatible: > + contains: > + const: qcom,pmi8950-wled > + > + then: > + properties: > + qcom,ovp-millivolt: > + enum: [ 17800, 19400, 29500, 31000 ] > + default: 29500 > + > + else: > + properties: > + qcom,ovp-millivolt: > + enum: [ 18100, 19600, 29600, 31100 ] > + default: 29600 Out of the supported ones: { .compatible = "qcom,pmi8950-wled", .data = (void *)4 }, { .compatible = "qcom,pmi8994-wled", .data = (void *)4 }, { .compatible = "qcom,pmi8998-wled", .data = (void *)4 }, { .compatible = "qcom,pm660l-wled", .data = (void *)4 }, I can confirm both allowed and default values for PMI8950/98/PM660L I could not find any data for PMI8994 (or PMI8996, the essentially PMI8994-revbump), but it's very probable that 8950 is an oddball, so: Reviewed-by: Konrad Dybcio Konrad