From: Stefan Wiehler <stefan.wiehler@nokia.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESENDv2] arm: topology: Consider clock-frequency property from parent /cpus node
Date: Mon, 23 Jan 2023 10:08:41 +0100 [thread overview]
Message-ID: <bfdea5aa-13d5-338f-bb5d-c05df45f7859@nokia.com> (raw)
In-Reply-To: <Y5xqVmO9ZHWYW3Du@shell.armlinux.org.uk>
Hi Russell,
>> + cn = of_get_cpu_node(cpu, NULL);
>> + if (!cn)
>> + pr_err("missing device node for CPU %d\n", cpu);
>> + cn = of_get_parent(cn);
>
> Doesn't this need to do an of_node_put()?
>
>> + if (!cn)
>> + pr_err("missing parent node for CPU %d\n", cpu);
>> + common_rate = of_get_property(cn, "clock-frequency",
&common_rate_len);
>
> And here too?
I have sent v2 in the meanwhile where I have refactored this part;
please review:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221221154213.24382-1-stefan.wiehler@nokia.com/
Kind regards,
Stefan Wiehler
prev parent reply other threads:[~2023-01-23 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 12:41 [PATCH RESENDv2] arm: topology: Consider clock-frequency property from parent /cpus node Stefan Wiehler
2022-12-16 12:53 ` Russell King (Oracle)
2023-01-23 9:08 ` Stefan Wiehler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfdea5aa-13d5-338f-bb5d-c05df45f7859@nokia.com \
--to=stefan.wiehler@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox