From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9FE342D75D for ; Thu, 16 Jul 2026 14:46:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784213188; cv=none; b=eovx7npncSPeTBSCZI76JU4Th5mQ64yXvcc8uNFI90mEeEerLd/AZWas/zsaGAbVvViNLJ3pjDecEMWfJHRZ5iN/tR9v1Lmcc6A7fceVrPyxljYdZa3gj2praP1Kt6SJenEJqg96VSHrYB7HqeVi7fz4ADQCeO+LTxDmay6stc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784213188; c=relaxed/simple; bh=v86wSwgrMuQBTbiZAMKuncJJPs8XClCe0ciN2/0afT0=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=OYYO4HAIaa09AuP1ozslVNjcuf+4BGWXeHcdyZm9m6Y9WANq7uqjIdbbP+3PI4nLyjk03Y5a1QduLGFQ0QfevMfJBEv8ny+Rg5QJwUElnDGg8mfcywfNOIC2xckds6Hus2iRDi076VX445p8HLuMQEOif7viGDHciNttT3ikOwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Ty9yFpxR; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Ty9yFpxR" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784213165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v86wSwgrMuQBTbiZAMKuncJJPs8XClCe0ciN2/0afT0=; b=Ty9yFpxRlmRz+GRI/PEkfJd9i/EtFOj7UBzAzq71sI91KDGgOAELqpEo879a4DPl+m6NYL y+ZtGtQdWFnUXs2o673jRy+fVdip8WF6cTD0NtK52Fv5BrYWEDNse5KK6xuclELGWmJxmU NNNpdIAR42t3RbgSFKz+t7g9f7diTvQ= Date: Thu, 16 Jul 2026 14:45:57 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Siratul Islam" Message-ID: TLS-Required: No Subject: Re: [PATCH 2/2] iio: magnetometer: add support for QST QMC6308 To: "Jorijn van der Graaf" , "Jonathan Cameron" Cc: "Jorijn van der Graaf" , "David Lechner" , "=?utf-8?B?TnVubyBTw6E=?=" , "Andy Shevchenko" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Luca Weiss" , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260716141837.83326-1-jorijnvdgraaf@catcrafts.net> References: <20260714202842.340293-1-jorijnvdgraaf@catcrafts.net> <20260714202842.340293-3-jorijnvdgraaf@catcrafts.net> <20260716141837.83326-1-jorijnvdgraaf@catcrafts.net> X-Migadu-Flow: FLOW_OUT July 16, 2026 at 8:18 PM, "Jorijn van der Graaf" wrote: >=20 >=20Hi Sirat, ... >=20 >=20>=20 >=20> Use reverse x-mas tree order. > >=20 >=20The natural initializer order is fixed by the dependencies here (map > comes from data, dev from map), so reverse xmas tree would need the > assignments split from the declarations; I'd rather keep them > together. Yep. Of course. That was a dumb suggestion. Should rely less on my patter= n=20 recognition.=20Though, you are only using "*map" it twice in that functio= n, so I'm not sure if extracting it into a variable is worth it. Specially considering it ma= kes the declarations look ugly. That said, I have opinions about your other replies, but I'm a bit busy n= ow so I'll get back to them later. >=20 ... >=20 > Thanks, > Jorijn > -- Best regards, Sirat