From: Rajendra Nayak <rnayak@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Todd Kjos <tkjos@google.com>,
Saravana Kannan <saravanak@google.com>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [RFC][PATCH] soc: qcom: rpmpd: Allow RPMPD driver to be loaded as a module
Date: Thu, 5 Mar 2020 12:26:17 +0530 [thread overview]
Message-ID: <bfea3aec-3a0b-9374-eec2-0a435cf68e04@codeaurora.org> (raw)
In-Reply-To: <20200305063254.GC264362@yoga>
>> -core_initcall(rpmpd_init);
>> +module_init(rpmpd_init);
>
> Can't you keep this as core_initcall(), for the times when its builtin?
>
> Additionally I believe you should add a call to unregister the driver,
and implement a .remove?
> and drop the suppress_bind_attrs.
>
>> +MODULE_LICENSE("GPL");
>
> "GPL v2" per the SPDX?
>
> Regards,
> Bjorn
>
>> --
>> 2.17.1
>>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-03-05 6:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 5:42 [RFC][PATCH] soc: qcom: rpmpd: Allow RPMPD driver to be loaded as a module John Stultz
2020-03-05 6:32 ` Bjorn Andersson
2020-03-05 6:56 ` Rajendra Nayak [this message]
2020-03-18 19:36 ` John Stultz
2020-03-05 6:37 ` Rajendra Nayak
2020-03-18 19:38 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfea3aec-3a0b-9374-eec2-0a435cf68e04@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox