From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BDA3C433FE for ; Fri, 11 Feb 2022 17:42:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343727AbiBKRmx (ORCPT ); Fri, 11 Feb 2022 12:42:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344629AbiBKRmw (ORCPT ); Fri, 11 Feb 2022 12:42:52 -0500 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78837D42 for ; Fri, 11 Feb 2022 09:42:50 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id n5so7406416ilk.12 for ; Fri, 11 Feb 2022 09:42:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AMl5Q0l7ZBAg1CxVaEuv9tRWUWqxdjJpFGZMnk/aFes=; b=dNGqNvfx+XKo5zJD/uEbB2fpRt+NFL+fhiO5iceJWSW2cNK50VGMqcoieBtuvf4d3+ jEprErP6DRajqrEvksNJKmN5CL94fYw5s8INt4+TcaVgM+oyBuDe1rLa644xJAaCCA3W YpPgKf2Lh/eAZ97rqSRt0owCG3J8a0t8c0VcQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AMl5Q0l7ZBAg1CxVaEuv9tRWUWqxdjJpFGZMnk/aFes=; b=x9GBrHTKfb8cXv4oGn6e/dpITxHgR6iJ/RKvNZVdYxpPuUb1wgbGcm3FGE6LN41XmB l4+r23Wc/+9rihqL9Y4J4P9GINNckcnXCa/bs3S/ZFcvohJHxQH374i4yiWP/BaUliKm bo3fdie9Jo/bcBH/DLAXzq6SM8J3eMs3e05C3qYw/iL85GR9otLXOTrvyw1mL0bKHa07 49bCXC8998zB08Ei9jsBXiczOWkVTh1QljLo0FjpdqKY59+76QNk2BbdAUVIUQRnGkU7 Pp9IOlqMkijQJhyZtcBRt39hz3SrGD+u2t4sSpxM4XQCsE0b83CPEX1sBP/kq27nFhQI 41jw== X-Gm-Message-State: AOAM531v+3kuFDY5z7FVdmyIk8Sk9vm1eQ3HeSBmrD0jN9hR2ardfhDN LHWqALHed2Q5jDhNhITHAiT/wwdAtOIo6w== X-Google-Smtp-Source: ABdhPJzzOoMxzA43l+WUTJEuCQn3QALtkrzfNcOD73zJZ4CC4hxTj1Pfbl8rlwihxlkhWcrl4ODCJg== X-Received: by 2002:a92:c644:: with SMTP id 4mr1512366ill.211.1644601369951; Fri, 11 Feb 2022 09:42:49 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id d12sm13057140ilv.42.2022.02.11.09.42.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 09:42:49 -0800 (PST) Subject: Re: [PATCH v2] usbip: vudc: Make use of the helper macro LIST_HEAD() To: Cai Huoqing , Greg Kroah-Hartman Cc: Valentina Manea , Shuah Khan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220211012807.7415-1-cai.huoqing@linux.dev> From: Shuah Khan Message-ID: Date: Fri, 11 Feb 2022 10:42:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220211012807.7415-1-cai.huoqing@linux.dev> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/22 6:28 PM, Cai Huoqing wrote: > Replace "struct list_head head = LIST_HEAD_INIT(head)" with > "LIST_HEAD(head)" to simplify the code. > > LIST_HEAD() helps to clean up the code "struct list_head vudc_devices =", > only to care about the variable 'vudc_devices'. > > Signed-off-by: Cai Huoqing > --- > v1->v2: update the changelog to explain why this change simplifies the code. > > drivers/usb/usbip/vudc_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/vudc_main.c b/drivers/usb/usbip/vudc_main.c > index 678faa82598c..d43252b77efd 100644 > --- a/drivers/usb/usbip/vudc_main.c > +++ b/drivers/usb/usbip/vudc_main.c > @@ -26,7 +26,7 @@ static struct platform_driver vudc_driver = { > }, > }; > > -static struct list_head vudc_devices = LIST_HEAD_INIT(vudc_devices); > +static LIST_HEAD(vudc_devices); > > static int __init init(void) > { > Hi Greg, Please pick this up. Reviewed-by: Shuah Khan thanks, -- Shuah