public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Akira Yokosawa <akiyks@gmail.com>
To: carlodelos90@gmail.com
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH] docs: Fix backticks in README instructions
Date: Tue, 21 Jan 2025 12:43:59 +0900	[thread overview]
Message-ID: <bffb09b8-8e9d-471c-871c-2fb3605dc7ed@gmail.com> (raw)
In-Reply-To: <20250121003056.10930-1-carlodelos90@gmail.com>

Hello,

carlodelos90 wrote:
> The commands `make pdfdocs` and `make htmldocs` were incorrectly formatted
> with only two backticks, which caused confusion and didn't render properly
> in some contexts.

Do you mean:

... One example is GitHub where top-level README is assumed to be in
the GitHub dialect of Markdown.

???

>                   This change updates the documentation to use triple
> backticks for consistency and clarity.

Obviously, triple backticks don't work in other contexts.

So your "fix" breaks assumption of others.

I think GitHub can render its README pane in reST format if you add a
symlink of README.rst -> README.  No?

> 
> Signed-off-by: carlodelos90 <carlodelos90@gmail.com>

Do You normally sign a contract using the name of "carlodelos90"?

Signed-off-by should be regarded as a formal statement that you
have the right to submit a patch.

See "Sign your work - the Developer’s Certificate of Origin"
in Documentation/process/submitting-patches.rst.

In your future submissions, please use your real name for signing off
unless you have a good reason not to do so.

I'm not sure if adding a symlink for the sake of GitHub compatibility
is acceptable or not.  But it looks to me worth an attempt at least.

        Thanks, Akira


  reply	other threads:[~2025-01-21  3:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21  0:30 [PATCH] docs: Fix backticks in README instructions carlodelos90
2025-01-21  3:43 ` Akira Yokosawa [this message]
2025-01-21 19:14   ` Jonathan Corbet
  -- strict thread matches above, loose matches on Subject: below --
2025-01-21 23:02 carlodelos90
2025-01-22  9:26 ` Akira Yokosawa
2025-01-22 16:54 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bffb09b8-8e9d-471c-871c-2fb3605dc7ed@gmail.com \
    --to=akiyks@gmail.com \
    --cc=carlodelos90@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox