From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A3DF3CD8DE for ; Thu, 9 Jul 2026 06:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783579969; cv=none; b=GMl908g8Pwt4on3bbmfbTCSXyY4OjY9QkQ6ojAHGvaoej06O2rt80lYCodGGRdtJYx/R85yG+9BM6rifz94pYMTwA0l+/OVeZtonhQf7SMIa42GUqxjfKCOH9L3xvkctNutk17Vmn2VNM3KFqleo+8E8nE/e3PuMU1gI+td66WE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783579969; c=relaxed/simple; bh=LJAMwt18nM4dwtPzHon2Kp84xpwGzRTygNda52SNCEo=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=jGP1ZCOTYH+CW/2Y/v2V+FJfj0n+OLIkTWGL/lCb/7K1W25/Ri/mzw6I0IQ4mf7n48DjmF/Prn43LKOA+30NAAyKlmMdF16O6iR4xN5sKywWMl26ZGZDPa3lvMC7NeEJ5t8sS64YA34jjO6bSconAILmVkaE9mv6cHDkkPIBTCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P9yFolVh; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P9yFolVh" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c85b73ffb52so905977a12.3 for ; Wed, 08 Jul 2026 23:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783579968; x=1784184768; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=UdnA/P7mCAyiVanyfsOozTh6jneyd7wup9/vb2CGq8A=; b=P9yFolVhTem/sJMn+Xj3V9HrYqG6ZL66tezEpEl+6Z6nwYOPx895fhHaeVATWQ7G1U ynZEDZoEsL0PBgO8rykx1UfrbjotTQOnxdv3cV8FOXjdZNwoQXoyrBnHGhAfUO8zqp9p hizXYQM9pnui7qzkuHCqrD///bJrbYB2aK6FjgcPG3GSSZrSYCdW3+FV3mGnzM0s8eFj ZGysKbwu1OsdIsq/pDrFypTiv4hmBmY2pjAeKOT9yjlPfvmJibh9lhJyzeahh8lQRQGj LgsXV2yUMFEtm13V8QYzDlFYKdU9Vf0Dtn8mO9VQ5qwHGh+ysm5C4dUoKgT+zmfv31sW 1rmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783579968; x=1784184768; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UdnA/P7mCAyiVanyfsOozTh6jneyd7wup9/vb2CGq8A=; b=k1BbfGnorQ+ZOJaFOSgE8FkrIy5btSDuanxSxwS3+SxhD2OThQ0RQdYs2+jqi4Gxmj oVV/osFHp/aE6f0esgl+IckhCvnCyAkCDVnjlXpQke6+ZDU7DpnNWgLxB1SSEqrxFOog /zc04YASoaSz3c5xh9ckxJTW+YvUJafnx5ztpI5AWZpyP20SdzQzQjt3NnjvqA2Wg05n yJe5gu/YeTynw0rBFRVY+D2DgFR3qbi3dvoYWxTH7ofmwa1E/lnI0veqc8RvcSoFqNwN wyooNxzfjJzKnoIm+tdX9EHdRslY5lA9Q6FqruRycKPHkYyIULAIasjjvsXhTy83QvDf AQtg== X-Forwarded-Encrypted: i=1; AHgh+RrSwKeNrkZSzBzmfkNBVlAL9TKhKglS0nd9XbKJHicNLP4vFq6KQA+Dpw8eZDmyN7cKpyJUemtEgf7EvM8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3ZFvuuwwBOd9875nRmNDHmGuT+cU5mG2YWoWd5gZHTpgq67uL 7Po1gzQ8Qh7FsArFB6lxu0AWO6yiCAAZT+OuT16q1Qu3rTMVydyAUX20 X-Gm-Gg: AfdE7ck9ebRJblxEforImkiXLKB/kqFp34qeWBr9MoRD193kusKcjMFAm7IeuwBBetg CNkzXfLPYGsxNZjsr4Q0iVwsnZr+uu7brsP8Hj06hxzT+M4PqAHXR20HzjfqmvaYPAMf0O/DGRV SrGCXOPDcPRN5CSwV4YL5B3ZUfSKCOsWdzk/Vv5gBpam7AWQLfNDvbDeu/+qsAeZ005cKmtJwNV QOFxfxD42bUAJzq52VPzZDv3NQCxhi7PU5/vl3zpcrhoP2PIO5eK05Ml7sj+PRhiK/4dJEmWRL0 dHj5fRhz9AVv0TKpF9hQoaRnP6PZUsaUA/clkIR5fxhrFnxmT+c5XWZXC9vFEHZ1FIOdVdiYABC IjI+Hr7AhAl2j6PMzaEcz+bSoYYV1vCVpoDdjE2Dgue9CWxBv60DhFW3hB9xdkcn/9Urvw0himQ s8JVtaHIrsbqo= X-Received: by 2002:a05:6a20:d708:b0:3bf:6c04:a813 with SMTP id adf61e73a8af0-3c0bd1595c4mr7398767637.52.1783579967832; Wed, 08 Jul 2026 23:52:47 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659666e7sm33453985c88.7.2026.07.08.23.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 23:52:47 -0700 (PDT) From: Ritesh Harjani (IBM) To: Thorsten Blum , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Josh Boyer , Grant Likely , Tony Breeds , Alistair Popple , Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Thorsten Blum Subject: Re: [PATCH 2/3] powerpc/boot: Fix treeboot-currituck CPU node lookup check In-Reply-To: <20260702211554.56923-5-thorsten.blum@linux.dev> Date: Thu, 09 Jul 2026 12:22:20 +0530 Message-ID: References: <20260702211554.56923-4-thorsten.blum@linux.dev> <20260702211554.56923-5-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thorsten Blum writes: > fdt_node_offset_by_prop_value() returns a negative error code on > failure - fix the check accordingly. > > Fixes: 228d55053397 ("powerpc/47x: Add support for the new IBM currituck platform") > Signed-off-by: Thorsten Blum Looks good to me. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM) > --- > arch/powerpc/boot/treeboot-currituck.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/treeboot-currituck.c b/arch/powerpc/boot/treeboot-currituck.c > index d53e8a592f81..5b5363b74f9f 100644 > --- a/arch/powerpc/boot/treeboot-currituck.c > +++ b/arch/powerpc/boot/treeboot-currituck.c > @@ -102,7 +102,7 @@ void platform_init(void) > > node = fdt_node_offset_by_prop_value(_dtb_start, -1, "device_type", > "cpu", sizeof("cpu")); > - if (!node) > + if (node < 0) > fatal("Cannot find cpu node\n"); > timebase = fdt_getprop(_dtb_start, node, "timebase-frequency", &size); > if (timebase && (size == 4))