linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc
@ 2025-06-12  2:39 Lijuan Gao
  2025-06-12  2:39 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number Lijuan Gao
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Lijuan Gao @ 2025-06-12  2:39 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
	Jassi Brar, Konrad Dybcio, Ling Xu, Tengfei Fan, Dmitry Baryshkov
  Cc: kernel, Krzysztof Kozlowski, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel, Lijuan Gao

The Ready and Handover interrupt numbers for sa8775p are incorrect. The
correct interrupt numbers are as follows. So they need to be corrected.

Fatal interrupt - 0
Ready interrupt - 1
Handover interrupt - 2
Stop acknowledge interrupt - 3

Signed-off-by: Lijuan Gao <lijuan.gao@oss.qualcomm.com>
---
Lijuan Gao (2):
      dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number
      arm64: dts: qcom: sa8775p: Correct the interrupt for remoteproc

 .../devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml       |  2 +-
 arch/arm64/boot/dts/qcom/sa8775p.dtsi                          | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)
---
base-commit: b27cc623e01be9de1580eaa913508b237a7a9673
change-id: 20250611-correct_interrupt_for_remoteproc-9cc1af90abf7

Best regards,
-- 
Lijuan Gao <lijuan.gao@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number
  2025-06-12  2:39 [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc Lijuan Gao
@ 2025-06-12  2:39 ` Lijuan Gao
  2025-06-13 14:09   ` Dmitry Baryshkov
  2025-06-12  2:39 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Correct the interrupt for remoteproc Lijuan Gao
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Lijuan Gao @ 2025-06-12  2:39 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
	Jassi Brar, Konrad Dybcio, Ling Xu, Tengfei Fan, Dmitry Baryshkov
  Cc: kernel, Krzysztof Kozlowski, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel, Lijuan Gao

Correct the interrupt number of ready and handover in the DTS example.

Fixes: af5da7b0944c ("dt-bindings: remoteproc: qcom,sa8775p-pas: Document the SA8775p ADSP, CDSP and GPDSP")
Signed-off-by: Lijuan Gao <lijuan.gao@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
index a66007951d585b779a9de593851cf2317d3da79b..188a251940001b8535ee7005f1595f42f6ab9b34 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
@@ -144,8 +144,8 @@ examples:
 
         interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
                               <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
-                              <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,
                               <&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>,
+                              <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,
                               <&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>;
         interrupt-names = "wdog", "fatal", "ready", "handover", "stop-ack";
 

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: sa8775p: Correct the interrupt for remoteproc
  2025-06-12  2:39 [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc Lijuan Gao
  2025-06-12  2:39 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number Lijuan Gao
@ 2025-06-12  2:39 ` Lijuan Gao
  2025-06-12 17:07   ` Konrad Dybcio
  2025-06-17 21:30 ` (subset) [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc Bjorn Andersson
  2025-06-18 20:58 ` Bjorn Andersson
  3 siblings, 1 reply; 7+ messages in thread
From: Lijuan Gao @ 2025-06-12  2:39 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
	Jassi Brar, Konrad Dybcio, Ling Xu, Tengfei Fan, Dmitry Baryshkov
  Cc: kernel, Krzysztof Kozlowski, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel, Lijuan Gao

Fix the incorrect IRQ numbers for ready and handover on sa8775p.
The correct values are as follows:

Fatal interrupt - 0
Ready interrupt - 1
Handover interrupt - 2
Stop acknowledge interrupt - 3

Fixes: df54dcb34ff2e ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes")
Signed-off-by: Lijuan Gao <lijuan.gao@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sa8775p.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 45f536633f6449e6ce6bb0109b5446968921f684..f682a53e83e5be2899922f177837c21ea09096f8 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -5571,8 +5571,8 @@ remoteproc_gpdsp0: remoteproc@20c00000 {
 
 			interrupts-extended = <&intc GIC_SPI 768 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_gpdsp0_in 0 0>,
-					      <&smp2p_gpdsp0_in 2 0>,
 					      <&smp2p_gpdsp0_in 1 0>,
+					      <&smp2p_gpdsp0_in 2 0>,
 					      <&smp2p_gpdsp0_in 3 0>;
 			interrupt-names = "wdog", "fatal", "ready",
 					  "handover", "stop-ack";
@@ -5614,8 +5614,8 @@ remoteproc_gpdsp1: remoteproc@21c00000 {
 
 			interrupts-extended = <&intc GIC_SPI 624 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_gpdsp1_in 0 0>,
-					      <&smp2p_gpdsp1_in 2 0>,
 					      <&smp2p_gpdsp1_in 1 0>,
+					      <&smp2p_gpdsp1_in 2 0>,
 					      <&smp2p_gpdsp1_in 3 0>;
 			interrupt-names = "wdog", "fatal", "ready",
 					  "handover", "stop-ack";
@@ -5755,8 +5755,8 @@ remoteproc_cdsp0: remoteproc@26300000 {
 
 			interrupts-extended = <&intc GIC_SPI 578 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_cdsp0_in 0 IRQ_TYPE_EDGE_RISING>,
-					      <&smp2p_cdsp0_in 2 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_cdsp0_in 1 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp0_in 2 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_cdsp0_in 3 IRQ_TYPE_EDGE_RISING>;
 			interrupt-names = "wdog", "fatal", "ready",
 					  "handover", "stop-ack";
@@ -5887,8 +5887,8 @@ remoteproc_cdsp1: remoteproc@2a300000 {
 
 			interrupts-extended = <&intc GIC_SPI 798 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_cdsp1_in 0 IRQ_TYPE_EDGE_RISING>,
-					      <&smp2p_cdsp1_in 2 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_cdsp1_in 1 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp1_in 2 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_cdsp1_in 3 IRQ_TYPE_EDGE_RISING>;
 			interrupt-names = "wdog", "fatal", "ready",
 					  "handover", "stop-ack";
@@ -6043,8 +6043,8 @@ remoteproc_adsp: remoteproc@30000000 {
 
 			interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
-					      <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>;
 			interrupt-names = "wdog", "fatal", "ready", "handover",
 					  "stop-ack";

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Correct the interrupt for remoteproc
  2025-06-12  2:39 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Correct the interrupt for remoteproc Lijuan Gao
@ 2025-06-12 17:07   ` Konrad Dybcio
  0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2025-06-12 17:07 UTC (permalink / raw)
  To: Lijuan Gao, Bjorn Andersson, Mathieu Poirier, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
	Jassi Brar, Konrad Dybcio, Ling Xu, Tengfei Fan, Dmitry Baryshkov
  Cc: kernel, Krzysztof Kozlowski, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel

On 6/12/25 4:39 AM, Lijuan Gao wrote:
> Fix the incorrect IRQ numbers for ready and handover on sa8775p.
> The correct values are as follows:
> 
> Fatal interrupt - 0
> Ready interrupt - 1
> Handover interrupt - 2
> Stop acknowledge interrupt - 3
> 
> Fixes: df54dcb34ff2e ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes")
> Signed-off-by: Lijuan Gao <lijuan.gao@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number
  2025-06-12  2:39 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number Lijuan Gao
@ 2025-06-13 14:09   ` Dmitry Baryshkov
  0 siblings, 0 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2025-06-13 14:09 UTC (permalink / raw)
  To: Lijuan Gao
  Cc: Bjorn Andersson, Mathieu Poirier, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
	Jassi Brar, Konrad Dybcio, Ling Xu, Tengfei Fan, Dmitry Baryshkov,
	kernel, Krzysztof Kozlowski, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel

On Thu, Jun 12, 2025 at 10:39:32AM +0800, Lijuan Gao wrote:
> Correct the interrupt number of ready and handover in the DTS example.
> 
> Fixes: af5da7b0944c ("dt-bindings: remoteproc: qcom,sa8775p-pas: Document the SA8775p ADSP, CDSP and GPDSP")
> Signed-off-by: Lijuan Gao <lijuan.gao@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: (subset) [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc
  2025-06-12  2:39 [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc Lijuan Gao
  2025-06-12  2:39 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number Lijuan Gao
  2025-06-12  2:39 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Correct the interrupt for remoteproc Lijuan Gao
@ 2025-06-17 21:30 ` Bjorn Andersson
  2025-06-18 20:58 ` Bjorn Andersson
  3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2025-06-17 21:30 UTC (permalink / raw)
  To: Mathieu Poirier, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bartosz Golaszewski, Jassi Brar, Konrad Dybcio, Ling Xu,
	Tengfei Fan, Dmitry Baryshkov, Lijuan Gao
  Cc: kernel, Krzysztof Kozlowski, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel


On Thu, 12 Jun 2025 10:39:31 +0800, Lijuan Gao wrote:
> The Ready and Handover interrupt numbers for sa8775p are incorrect. The
> correct interrupt numbers are as follows. So they need to be corrected.
> 
> Fatal interrupt - 0
> Ready interrupt - 1
> Handover interrupt - 2
> Stop acknowledge interrupt - 3
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number
      commit: f6588dea0ab2873760b87b3ffbd02316e7826ee0

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: (subset) [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc
  2025-06-12  2:39 [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc Lijuan Gao
                   ` (2 preceding siblings ...)
  2025-06-17 21:30 ` (subset) [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc Bjorn Andersson
@ 2025-06-18 20:58 ` Bjorn Andersson
  3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2025-06-18 20:58 UTC (permalink / raw)
  To: Mathieu Poirier, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bartosz Golaszewski, Jassi Brar, Konrad Dybcio, Ling Xu,
	Tengfei Fan, Dmitry Baryshkov, Lijuan Gao
  Cc: kernel, Krzysztof Kozlowski, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel


On Thu, 12 Jun 2025 10:39:31 +0800, Lijuan Gao wrote:
> The Ready and Handover interrupt numbers for sa8775p are incorrect. The
> correct interrupt numbers are as follows. So they need to be corrected.
> 
> Fatal interrupt - 0
> Ready interrupt - 1
> Handover interrupt - 2
> Stop acknowledge interrupt - 3
> 
> [...]

Applied, thanks!

[2/2] arm64: dts: qcom: sa8775p: Correct the interrupt for remoteproc
      commit: 7bd7209e9cb11c8864e601d915008da088476f0c

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-06-18 20:58 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-12  2:39 [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc Lijuan Gao
2025-06-12  2:39 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number Lijuan Gao
2025-06-13 14:09   ` Dmitry Baryshkov
2025-06-12  2:39 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Correct the interrupt for remoteproc Lijuan Gao
2025-06-12 17:07   ` Konrad Dybcio
2025-06-17 21:30 ` (subset) [PATCH 0/2] Correct the ready and handover interrupt number for sa8775p remoteproc Bjorn Andersson
2025-06-18 20:58 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).