From: Boris Kolpackov <boris@codesynthesis.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kconfig: rename a variable in the lexer to a clearer name
Date: Wed, 29 Sep 2021 16:01:48 +0200 [thread overview]
Message-ID: <boris.20210929160100@codesynthesis.com> (raw)
In-Reply-To: <20210927125437.818092-2-masahiroy@kernel.org>
Masahiro Yamada <masahiroy@kernel.org> writes:
> In Kconfig, like Python, you can enclose a string by double-quotes or
> single-quotes. So, both "foo" and 'foo' are allowed.
>
> The variable, "str", is used to remember whether the string started with
> a double-quote or a single-quote.
>
> Rename it to a clearer name. The type should be 'char'.
LGTM.
Reviewed-by: Boris Kolpackov <boris@codesynthesis.com>
prev parent reply other threads:[~2021-09-29 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 12:54 [PATCH 1/2] kconfig: narrow the scope of variables in the lexer Masahiro Yamada
2021-09-27 12:54 ` [PATCH 2/2] kconfig: rename a variable in the lexer to a clearer name Masahiro Yamada
2021-09-29 14:01 ` Boris Kolpackov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=boris.20210929160100@codesynthesis.com \
--to=boris@codesynthesis.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox