From: Bill Davidsen <davidsen@tmr.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab.c remove impossible <0 check - size_t is not signed - patch is against 2.6.1-rc1-mm2
Date: Wed, 14 Jan 2004 20:13:16 -0500 [thread overview]
Message-ID: <bu4oqc$2dl$2@gatekeeper.tmr.com> (raw)
In-Reply-To: <1073576236.2340.34.camel@localhost.localdomain>
Joe Perches wrote:
> On Thu, 2004-01-08 at 02:16, Paul Jackson wrote:
>
>>Jason asked:
>>
>>>Well, anything wrong in cleaning them [unsigned compare warnings] up?
>
>
> In this case the warning is not unsigned compare but
> "comparison of .* is always [true|false]".
>
> This sort of code generally makes me think someone did something wrong,
> not just that the person added additional unnecessary checking.
Agreed, often muddy thinking.
--
bill davidsen <davidsen@tmr.com>
CTO TMR Associates, Inc
Doing interesting things with small computers since 1979
prev parent reply other threads:[~2004-01-15 1:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-08 1:20 [PATCH] mm/slab.c remove impossible <0 check - size_t is not signed - patch is against 2.6.1-rc1-mm2 Jesper Juhl
2004-01-08 3:08 ` Joe Perches
2004-01-08 9:33 ` Jesper Juhl
2004-01-08 10:16 ` Paul Jackson
2004-01-08 15:28 ` Jens Axboe
2004-01-08 19:33 ` Manfred Spraul
2004-01-08 15:37 ` Joe Perches
2004-01-15 1:13 ` Bill Davidsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='bu4oqc$2dl$2@gatekeeper.tmr.com' \
--to=davidsen@tmr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox