public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Miles Bader <miles@lsi.nec.co.jp>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
	davem@redhat.com, dwmw2@redhat.com
Subject: Re: [SERIAL] change_speed -> settermios change
Date: 06 Jan 2003 16:49:58 +0900	[thread overview]
Message-ID: <buo7kdibtuh.fsf@mcspd15.ucom.lsi.nec.co.jp> (raw)
In-Reply-To: <20030103161916.A19992@flint.arm.linux.org.uk>

Looks OK to me; as soon as you decide how the low-level driver should
limit the baud rate, I'll update nb85e_uart.c to do it (storing max/min in
the uart_port structure, as someone suggested, seems pretty convenient).

If unsupported termios flags are passed in, what should the low-level
function do?  Tweak the contents of *termios to reflect reality?

BTW, why the name `settermios'?  Something like `set_termios' seems easier
to read and more in keeping with the style used elsewhere in the
serial-port code.  [settermios brings back horrible memories of BSD kernel
code...]

Thanks,

-miles
-- 
Run away!  Run away!

      parent reply	other threads:[~2003-01-06  7:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-03 16:19 [SERIAL] change_speed -> settermios change Russell King
2003-01-06  7:02 ` David S. Miller
2003-01-06 11:36   ` Russell King
2003-01-06  7:49 ` Miles Bader [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buo7kdibtuh.fsf@mcspd15.ucom.lsi.nec.co.jp \
    --to=miles@lsi.nec.co.jp \
    --cc=davem@redhat.com \
    --cc=dwmw2@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles@gnu.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox