From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kim Seer Paller <kimseer.paller@analog.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH v3 1/2] dt-bindings: power/supply: Add ltc4162-f/s and ltc4015
Date: Wed, 20 Nov 2024 09:12:32 +0100 [thread overview]
Message-ID: <bwn36yetahe7bjwsrcx4lljn6r7ta4d2r6pacq4ccmxbkkurpo@vkgjle4ckl6b> (raw)
In-Reply-To: <20241119032304.23588-1-kimseer.paller@analog.com>
On Tue, Nov 19, 2024 at 11:23:03AM +0800, Kim Seer Paller wrote:
> Add LTC4162-F/S and LTC4015 to the supported devices of LTC4162-L.
> They share a common set of registers. The only differences lie in the
> resolution value of the scaling factor for battery voltage and battery
> current measurement, input voltage, and input current for different
> battery chemistries. The differences also include the calculation of
> setting and getting the actual voltage applied to the charge voltage,
> as well as getting the die temperature.
>
> This add compatible entries for ltc4162-f/s and ltc4015 and include
> datasheets for new devices.
>
> Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
> ---
> V2 -> V3: Described differences in the programming model between variants/devices.
> V1 -> V2: Modified commit message describing differences between
> variants/devices.
>
> .../devicetree/bindings/power/supply/ltc4162-l.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> index 29d536541..9b546150d 100644
> --- a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> @@ -17,12 +17,18 @@ description: |
> panels, etc., and a rechargeable Lithium-Ion/Polymer battery.
>
> Specifications about the charger can be found at:
> + https://www.analog.com/en/products/ltc4162-l.html
> + https://www.analog.com/en/products/ltc4162-f.html
> https://www.analog.com/en/products/ltc4162-s.html
> + https://www.analog.com/en/products/ltc4015.html
>
> properties:
> compatible:
> enum:
> - lltc,ltc4162-l
> + - lltc,ltc4162-f
> + - lltc,ltc4162-s
> + - lltc,ltc4015
Keep alphabetical order.
I assume these are not compatible.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-11-20 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 3:23 [PATCH v3 1/2] dt-bindings: power/supply: Add ltc4162-f/s and ltc4015 Kim Seer Paller
2024-11-19 3:23 ` [PATCH v3 2/2] power/supply: Add support for " Kim Seer Paller
2024-11-20 8:12 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bwn36yetahe7bjwsrcx4lljn6r7ta4d2r6pacq4ccmxbkkurpo@vkgjle4ckl6b \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kimseer.paller@analog.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox