From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751219AbdFDLC0 (ORCPT ); Sun, 4 Jun 2017 07:02:26 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35202 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbdFDLCK (ORCPT ); Sun, 4 Jun 2017 07:02:10 -0400 From: Heiner Kallweit Subject: [PATCH 2/3] nvmem: core: add locking to nvmem_find_cell To: Srinivas Kandagatla , Linux Kernel Mailing List References: <32c019d9-656d-6214-af2a-bef7e91dc1de@gmail.com> Message-ID: Date: Sun, 4 Jun 2017 13:01:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <32c019d9-656d-6214-af2a-bef7e91dc1de@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding entries to nvmem_cells and deleting entries from it is protected by nvmem_cells_mutex. Therefore this mutex should also protect iterating over the list. Signed-off-by: Heiner Kallweit --- drivers/nvmem/core.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 4e07f3f8..1aa6d25a 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -286,9 +286,15 @@ static struct nvmem_cell *nvmem_find_cell(const char *cell_id) { struct nvmem_cell *p; + mutex_lock(&nvmem_cells_mutex); + list_for_each_entry(p, &nvmem_cells, node) - if (p && !strcmp(p->name, cell_id)) + if (p && !strcmp(p->name, cell_id)) { + mutex_unlock(&nvmem_cells_mutex); return p; + } + + mutex_unlock(&nvmem_cells_mutex); return NULL; } -- 2.13.0