* [PATCHv5] platform/x86: ideapad-laptop: added support for some new buttons
@ 2025-04-17 11:24 Gašper Nemgar
2025-04-17 11:28 ` Ilpo Järvinen
0 siblings, 1 reply; 7+ messages in thread
From: Gašper Nemgar @ 2025-04-17 11:24 UTC (permalink / raw)
To: ikepanhc
Cc: hdegoede, ilpo.jarvinen, linux-kernel, platform-driver-x86,
Gašper Nemgar
Signed-off-by: Gašper Nemgar <gasper.nemgar@gmail.com>"
---
Changes in v5:
- Changed performance button to KE_KEY
Changes in v4:
- Changed performace button to KE_IGNORE
Changes in v3:
- Minor changes
Changes in v2:
- Added more codes that trigger with key combos (Fn+N, Fn+M, ...)
- Added performence toggle in wmi_notify()
Changes in v1:
- Added codes for buttons on laptop(performance, star, ...)
---
drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 17a09b778..320ce9d2d 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -1294,6 +1294,16 @@ static const struct key_entry ideapad_keymap[] = {
/* Specific to some newer models */
{ KE_KEY, 0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
{ KE_KEY, 0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
+ /* Star- (User Assignable Key) */
+ { KE_KEY, 0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
+ /* Eye */
+ { KE_KEY, 0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
+ /* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
+ { KE_IGNORE, 0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
+ /* shift + prtsc */
+ { KE_KEY, 0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
+ { KE_KEY, 0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
+ { KE_KEY, 0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
{ KE_END },
};
@@ -2080,6 +2090,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
data->integer.value);
+ /* performance button triggered by 0x3d */
+ if (data->integer.value == 0x3d) {
+ if (priv->dytc) {
+ platform_profile_cycle();
+ break;
+ }
+ }
+
/* 0x02 FnLock, 0x03 Esc */
if (data->integer.value == 0x02 || data->integer.value == 0x03)
ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCHv5] platform/x86: ideapad-laptop: added support for some new buttons
2025-04-17 11:24 [PATCHv5] platform/x86: ideapad-laptop: added support for some new buttons Gašper Nemgar
@ 2025-04-17 11:28 ` Ilpo Järvinen
0 siblings, 0 replies; 7+ messages in thread
From: Ilpo Järvinen @ 2025-04-17 11:28 UTC (permalink / raw)
To: Gašper Nemgar; +Cc: ikepanhc, Hans de Goede, LKML, platform-driver-x86
[-- Attachment #1: Type: text/plain, Size: 2301 bytes --]
On Thu, 17 Apr 2025, Gašper Nemgar wrote:
> Signed-off-by: Gašper Nemgar <gasper.nemgar@gmail.com>"
This too seems wrong. Using git send-email might be helpful as it can send
directly the file from git format-patch.
> ---
> Changes in v5:
> - Changed performance button to KE_KEY
> Changes in v4:
> - Changed performace button to KE_IGNORE
> Changes in v3:
> - Minor changes
> Changes in v2:
> - Added more codes that trigger with key combos (Fn+N, Fn+M, ...)
> - Added performence toggle in wmi_notify()
> Changes in v1:
> - Added codes for buttons on laptop(performance, star, ...)
> ---
> drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 17a09b778..320ce9d2d 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1294,6 +1294,16 @@ static const struct key_entry ideapad_keymap[] = {
> /* Specific to some newer models */
> { KE_KEY, 0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
> { KE_KEY, 0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
> + /* Star- (User Assignable Key) */
> + { KE_KEY, 0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
> + /* Eye */
> + { KE_KEY, 0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
> + /* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
> + { KE_IGNORE, 0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
> + /* shift + prtsc */
> + { KE_KEY, 0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
> + { KE_KEY, 0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
> + { KE_KEY, 0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
>
> { KE_END },
> };
> @@ -2080,6 +2090,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
> dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
> data->integer.value);
>
> + /* performance button triggered by 0x3d */
> + if (data->integer.value == 0x3d) {
> + if (priv->dytc) {
> + platform_profile_cycle();
> + break;
> + }
> + }
> +
> /* 0x02 FnLock, 0x03 Esc */
> if (data->integer.value == 0x02 || data->integer.value == 0x03)
> ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);
>
--
i.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCHv5] platform/x86: ideapad-laptop: added support for some new buttons
@ 2025-04-17 11:34 Gašper Nemgar
2025-04-17 12:01 ` Hans de Goede
0 siblings, 1 reply; 7+ messages in thread
From: Gašper Nemgar @ 2025-04-17 11:34 UTC (permalink / raw)
To: ikepanhc
Cc: hdegoede, ilpo.jarvinen, linux-kernel, platform-driver-x86,
Gašper Nemgar
Added entries to unsupported wmi codes in ideapad_keymap[]
and one check in wmi_nofify in order to get wmi code 0x13d to trigger platform_profile_cycle
Signed-off-by: Gašper Nemgar <gasper.nemgar@gmail.com>"
---
Changes in v5:
- Changed performance button to KE_KEY
Changes in v4:
- Changed performace button to KE_IGNORE
Changes in v3:
- Minor changes
Changes in v2:
- Added more codes that trigger with key combos (Fn+N, Fn+M, ...)
- Added performence toggle in wmi_notify()
Changes in v1:
- Added codes for buttons on laptop(performance, star, ...)
---
drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 17a09b778..320ce9d2d 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -1294,6 +1294,16 @@ static const struct key_entry ideapad_keymap[] = {
/* Specific to some newer models */
{ KE_KEY, 0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
{ KE_KEY, 0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
+ /* Star- (User Assignable Key) */
+ { KE_KEY, 0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
+ /* Eye */
+ { KE_KEY, 0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
+ /* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
+ { KE_IGNORE, 0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
+ /* shift + prtsc */
+ { KE_KEY, 0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
+ { KE_KEY, 0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
+ { KE_KEY, 0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
{ KE_END },
};
@@ -2080,6 +2090,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
data->integer.value);
+ /* performance button triggered by 0x3d */
+ if (data->integer.value == 0x3d) {
+ if (priv->dytc) {
+ platform_profile_cycle();
+ break;
+ }
+ }
+
/* 0x02 FnLock, 0x03 Esc */
if (data->integer.value == 0x02 || data->integer.value == 0x03)
ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCHv5] platform/x86: ideapad-laptop: added support for some new buttons
2025-04-17 11:34 Gašper Nemgar
@ 2025-04-17 12:01 ` Hans de Goede
0 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2025-04-17 12:01 UTC (permalink / raw)
To: Gašper Nemgar, ikepanhc
Cc: ilpo.jarvinen, linux-kernel, platform-driver-x86
Hi Gašper,
On 17-Apr-25 1:34 PM, Gašper Nemgar wrote:
> Added entries to unsupported wmi codes in ideapad_keymap[]
> and one check in wmi_nofify in order to get wmi code 0x13d to trigger platform_profile_cycle
>
> Signed-off-by: Gašper Nemgar <gasper.nemgar@gmail.com>"
> ---
> Changes in v5:
> - Changed performance button to KE_KEY
> Changes in v4:
> - Changed performace button to KE_IGNORE
> Changes in v3:
> - Minor changes
> Changes in v2:
> - Added more codes that trigger with key combos (Fn+N, Fn+M, ...)
> - Added performence toggle in wmi_notify()
> Changes in v1:
> - Added codes for buttons on laptop(performance, star, ...)
> ---
> drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 17a09b778..320ce9d2d 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1294,6 +1294,16 @@ static const struct key_entry ideapad_keymap[] = {
> /* Specific to some newer models */
> { KE_KEY, 0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
> { KE_KEY, 0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
> + /* Star- (User Assignable Key) */
> + { KE_KEY, 0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
> + /* Eye */
> + { KE_KEY, 0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
> + /* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
> + { KE_IGNORE, 0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
Almost there, you still forgot to change this KE_IGNORE back to KE_KEY,
also you forgot to bump the version to 6 for this v6 patch.
Regards,
Hans
> + /* shift + prtsc */
> + { KE_KEY, 0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
> + { KE_KEY, 0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
> + { KE_KEY, 0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
>
> { KE_END },
> };
> @@ -2080,6 +2090,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
> dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
> data->integer.value);
>
> + /* performance button triggered by 0x3d */
> + if (data->integer.value == 0x3d) {
> + if (priv->dytc) {
> + platform_profile_cycle();
> + break;
> + }
> + }
> +
> /* 0x02 FnLock, 0x03 Esc */
> if (data->integer.value == 0x02 || data->integer.value == 0x03)
> ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCHv5] platform/x86: ideapad-laptop: added support for some new buttons
@ 2025-04-17 10:57 Gašper Nemgar
2025-04-17 11:05 ` Hans de Goede
0 siblings, 1 reply; 7+ messages in thread
From: Gašper Nemgar @ 2025-04-17 10:57 UTC (permalink / raw)
To: ikepanhc
Cc: hdegoede, ilpo.jarvinen, linux-kernel, platform-driver-x86,
Gašper Nemgar
Added entries to unsupported wmi codes in ideapad_keymap[]
and one check in wmi_nofify in order to get wmi code 0x13d to trigger platform_profile_cycle
Signed-off-by: Gašper Nemgar <gasper.nemgar@gmail.com>"
---
Changes in v5:
- Changed performance button to KE_KEY
Changes in v4:
- Changed performace button to KE_IGNORE
Changes in v3:
- Minor changes
Changes in v2:
- Added more codes that trigger with key combos (Fn+N, Fn+M, ...)
- Added performence toggle in wmi_notify()
Changes in v1:
- Added codes for buttons on laptop(performance, star, ...)
---
drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 17a09b778..72d3306ef 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -1294,6 +1294,16 @@ static const struct key_entry ideapad_keymap[] = {
/* Specific to some newer models */
{ KE_KEY, 0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
{ KE_KEY, 0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
+ /* Star- (User Asignable Key) */
+ { KE_KEY, 0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
+ /* Eye */
+ { KE_KEY, 0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
+ /* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
+ { KE_IGNORE, 0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
+ /* shift + prtsc */
+ { KE_KEY, 0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
+ { KE_KEY, 0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
+ { KE_KEY, 0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
{ KE_END },
};
@@ -2080,6 +2090,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
data->integer.value);
+ /* performance button triggered by 0x3d */
+ if (data->integer.value == 0x3d) {
+ if (priv->dytc) {
+ platform_profile_cycle();
+ break;
+ }
+ }
+
/* 0x02 FnLock, 0x03 Esc */
if (data->integer.value == 0x02 || data->integer.value == 0x03)
ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCHv5] platform/x86: ideapad-laptop: added support for some new buttons
2025-04-17 10:57 Gašper Nemgar
@ 2025-04-17 11:05 ` Hans de Goede
2025-04-17 11:17 ` Gašper Nemgar
0 siblings, 1 reply; 7+ messages in thread
From: Hans de Goede @ 2025-04-17 11:05 UTC (permalink / raw)
To: Gašper Nemgar, ikepanhc, ALOK TIWARI
Cc: ilpo.jarvinen, linux-kernel, platform-driver-x86
Hi Gašper,
On 17-Apr-25 12:57 PM, Gašper Nemgar wrote:
> Added entries to unsupported wmi codes in ideapad_keymap[]
> and one check in wmi_nofify in order to get wmi code 0x13d to trigger platform_profile_cycle
>
> Signed-off-by: Gašper Nemgar <gasper.nemgar@gmail.com>"
> ---
> Changes in v5:
> - Changed performance button to KE_KEY
Thank you for the new version, but you seem to not actually
have made this change to the code.
Also below you still have "User Asignable Key" instead of
"User Assignable Key" (with double ss in assignable)
You also still have 2 spaces instead of one after 0x3d in:
/* performance button triggered by 0x3d */
(both pointed out by Alok for v4)
Maybe you accidentally send out an old version of the code?
Regards,
Hans
> Changes in v4:
> - Changed performace button to KE_IGNORE
> Changes in v3:
> - Minor changes
> Changes in v2:
> - Added more codes that trigger with key combos (Fn+N, Fn+M, ...)
> - Added performence toggle in wmi_notify()
> Changes in v1:
> - Added codes for buttons on laptop(performance, star, ...)
> ---
> drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 17a09b778..72d3306ef 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1294,6 +1294,16 @@ static const struct key_entry ideapad_keymap[] = {
> /* Specific to some newer models */
> { KE_KEY, 0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
> { KE_KEY, 0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
> + /* Star- (User Asignable Key) */
> + { KE_KEY, 0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
> + /* Eye */
> + { KE_KEY, 0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
> + /* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
> + { KE_IGNORE, 0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
> + /* shift + prtsc */
> + { KE_KEY, 0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
> + { KE_KEY, 0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
> + { KE_KEY, 0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
>
> { KE_END },
> };
> @@ -2080,6 +2090,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
> dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
> data->integer.value);
>
> + /* performance button triggered by 0x3d */
> + if (data->integer.value == 0x3d) {
> + if (priv->dytc) {
> + platform_profile_cycle();
> + break;
> + }
> + }
> +
> /* 0x02 FnLock, 0x03 Esc */
> if (data->integer.value == 0x02 || data->integer.value == 0x03)
> ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCHv5] platform/x86: ideapad-laptop: added support for some new buttons
2025-04-17 11:05 ` Hans de Goede
@ 2025-04-17 11:17 ` Gašper Nemgar
0 siblings, 0 replies; 7+ messages in thread
From: Gašper Nemgar @ 2025-04-17 11:17 UTC (permalink / raw)
To: Hans de Goede
Cc: ikepanhc, ALOK TIWARI, ilpo.jarvinen, linux-kernel,
platform-driver-x86
Hello,
I see that there has been a mistake.
Thanks, I will send again.
Gašper
On Thu, 17 Apr 2025 at 13:05, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi Gašper,
>
> On 17-Apr-25 12:57 PM, Gašper Nemgar wrote:
> > Added entries to unsupported wmi codes in ideapad_keymap[]
> > and one check in wmi_nofify in order to get wmi code 0x13d to trigger platform_profile_cycle
> >
> > Signed-off-by: Gašper Nemgar <gasper.nemgar@gmail.com>"
> > ---
> > Changes in v5:
> > - Changed performance button to KE_KEY
>
> Thank you for the new version, but you seem to not actually
> have made this change to the code.
>
> Also below you still have "User Asignable Key" instead of
> "User Assignable Key" (with double ss in assignable)
>
> You also still have 2 spaces instead of one after 0x3d in:
>
> /* performance button triggered by 0x3d */
>
> (both pointed out by Alok for v4)
>
> Maybe you accidentally send out an old version of the code?
>
> Regards,
>
> Hans
>
>
>
>
>
>
>
>
>
>
> > Changes in v4:
> > - Changed performace button to KE_IGNORE
> > Changes in v3:
> > - Minor changes
> > Changes in v2:
> > - Added more codes that trigger with key combos (Fn+N, Fn+M, ...)
> > - Added performence toggle in wmi_notify()
> > Changes in v1:
> > - Added codes for buttons on laptop(performance, star, ...)
> > ---
> > drivers/platform/x86/ideapad-laptop.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> > index 17a09b778..72d3306ef 100644
> > --- a/drivers/platform/x86/ideapad-laptop.c
> > +++ b/drivers/platform/x86/ideapad-laptop.c
> > @@ -1294,6 +1294,16 @@ static const struct key_entry ideapad_keymap[] = {
> > /* Specific to some newer models */
> > { KE_KEY, 0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
> > { KE_KEY, 0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
> > + /* Star- (User Asignable Key) */
> > + { KE_KEY, 0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
> > + /* Eye */
> > + { KE_KEY, 0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
> > + /* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
> > + { KE_IGNORE, 0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
> > + /* shift + prtsc */
> > + { KE_KEY, 0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
> > + { KE_KEY, 0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
> > + { KE_KEY, 0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
> >
> > { KE_END },
> > };
> > @@ -2080,6 +2090,14 @@ static void ideapad_wmi_notify(struct wmi_device *wdev, union acpi_object *data)
> > dev_dbg(&wdev->dev, "WMI fn-key event: 0x%llx\n",
> > data->integer.value);
> >
> > + /* performance button triggered by 0x3d */
> > + if (data->integer.value == 0x3d) {
> > + if (priv->dytc) {
> > + platform_profile_cycle();
> > + break;
> > + }
> > + }
> > +
> > /* 0x02 FnLock, 0x03 Esc */
> > if (data->integer.value == 0x02 || data->integer.value == 0x03)
> > ideapad_fn_lock_led_notify(priv, data->integer.value == 0x02);
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-04-17 12:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-17 11:24 [PATCHv5] platform/x86: ideapad-laptop: added support for some new buttons Gašper Nemgar
2025-04-17 11:28 ` Ilpo Järvinen
-- strict thread matches above, loose matches on Subject: below --
2025-04-17 11:34 Gašper Nemgar
2025-04-17 12:01 ` Hans de Goede
2025-04-17 10:57 Gašper Nemgar
2025-04-17 11:05 ` Hans de Goede
2025-04-17 11:17 ` Gašper Nemgar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox