From: Guy Durrieu <guy.durrieu@cegetel.net>
To: Kishon Vijay Abraham I <kvijayab@amd.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Santosh Shukla <santosh.shukla@amd.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Borislav Petkov <bpetkov@amd.com>, Leo Duran <leo.duran@amd.com>,
1033732@bugs.debian.org
Subject: Re: [PATCH v2] x86/acpi/boot: Do not register processors that cannot be onlined for x2apic
Date: Sun, 2 Apr 2023 12:41:46 +0200 [thread overview]
Message-ID: <c02a2a2f-2b40-e13e-ac40-e5d19a66b5ba@cegetel.net> (raw)
In-Reply-To: <20230105041059.39366-1-kvijayab@amd.com>
Le 05/01/2023 à 05:10, Kishon Vijay Abraham I a écrit :
> Section 5.2.12.12 Processor Local x2APIC Structure in the ACPI v6.5
> spec mandates that both "enabled" and "online capable" Local APIC Flags
> should be used to determine if the processor is usable or not.
>
> However, Linux doesn't use the "online capable" flag for x2APIC to
> determine if the processor is usable. As a result, cpu_possible_mask has
> incorrect value and results in more memory getting allocated for per_cpu
> variables than it is going to be used.
>
> Make sure Linux parses both "enabled" and "online capable" flags for
> x2APIC to correctly determine if the processor is usable.
>
> Fixes: aa06e20f1be6 ("x86/ACPI: Don't add CPUs that are not online capable")
> Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>
> Reported-by: Leo Duran <leo.duran@amd.com>
> Signed-off-by: Kishon Vijay Abraham I <kvijayab@amd.com>
Hello everyone,
My system worked fine with kernel 6.1.15, but stopped booting after
upgrading to 6.1.20 and resulted in a kernel panic:
---
[ 0.117782] Kernel panic — not syncing: timer doesn’t work through Interrupt-remapped IO-APIC
[ 0.117848] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.1.0-7-and64 #1 Debian 6.1.20-1
[ 0.117913] Hardware name: Gigabyte Technology Co., Ltd. ABS50M-Gaming 3/AB350M-Gaming 3-CF, BIOS F50d 07/02/2020
[ 0.117982] Call Trace:
[ 0.118634] <TASK>
[ 0.118685] dump_stack_lvl+0x44/0x5c
[ 0.118143] panic+0x118/0x2ed
[ 0.118198] panic_if_irq_remap.cold+0x5/0x5
[ 0.118256] setup_I0_APIC+0x3db/0x64b
[ 0.118313] ? _raw_spin_unlock_irqrestore+0x23/0x40
[ 0.118372] ? clear_IO_APIC_pin+0x169/0x240
[ 0.118429] apic_intr_node_init+0x101/0x106
[ 0.118485] x86_late_time_init+0x20/0x34
[ 0.118542] start_kerne1+0x667/0x727
[ 0.118598] secondary_startup_64_no_verify+0xe5/0xeb
[ 0.118658] </TASK>
[ 0.118711] ---[ end Kernel panic - not syncing: timer doesn’t work through Interrupt-remapped IO-APIC J---
---
I tried an update of the BIOS up to F51h without any effect.
I sent a bug report to Debian Bug Tracking System. In reply Bjørn Mork
identified ce7d894bed1a539a8d6cff42f6f78f9db0c9c26b from the linux-6.1.y
branch as the likely culprit.
After building a 6.1.20 kernel with just that commit reverted, my system boots normally again.
I reported that all tohttps://bugs.debian.org/1033732 and were asked to report the issue 'upstream' (which is what that mail is).
Hope it will help!
Best regards.
-- Guy Durrieu
next prev parent reply other threads:[~2023-04-02 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 4:10 [PATCH v2] x86/acpi/boot: Do not register processors that cannot be onlined for x2apic Kishon Vijay Abraham I
2023-01-05 17:09 ` Rafael J. Wysocki
2023-01-05 22:22 ` Borislav Petkov
2023-01-10 13:03 ` Rafael J. Wysocki
2023-01-10 18:23 ` Borislav Petkov
2023-01-06 0:57 ` Zhang, Rui
2023-01-10 18:41 ` [tip: x86/boot] x86/acpi/boot: Do not register processors that cannot be onlined for x2APIC tip-bot2 for Kishon Vijay Abraham I
2023-04-02 10:41 ` Guy Durrieu [this message]
2023-04-02 10:57 ` [PATCH v2] x86/acpi/boot: Do not register processors that cannot be onlined for x2apic Borislav Petkov
2023-04-02 13:13 ` Guy Durrieu
2023-04-02 15:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c02a2a2f-2b40-e13e-ac40-e5d19a66b5ba@cegetel.net \
--to=guy.durrieu@cegetel.net \
--cc=1033732@bugs.debian.org \
--cc=bp@alien8.de \
--cc=bpetkov@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvijayab@amd.com \
--cc=len.brown@intel.com \
--cc=leo.duran@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=santosh.shukla@amd.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox