RE: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without HAS_IOPORT support

Brian Cain
2024-04-03T14:51:25Z

> -----Original Message-----
> From: Niklas Schnelle <schnelle@linux.ibm.com>
> Sent: Wednesday, April 3, 2024 8:25 AM
> To: Brian Cain <bcain@quicinc.com>
> Cc: linux-hexagon@vger.kernel.org; Arnd Bergmann <arnd@kernel.org>;
> Heiko Carstens <hca@linux.ibm.com>; linux-kernel@vger.kernel.org; Niklas
> Schnelle <schnelle@linux.ibm.com>
> Subject: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> HAS_IOPORT support
>
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>
> In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
> compile time. As hexagon does not support I/O port access it also
> the GENERIC_IOMAP mechanism of dynamically choosing between I/O port
> and
> MMIO access doesn't work so don't select it.
>
> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> arch/hexagon/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> index e233b5efa276..5ea1bf4b7d4f 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -31,7 +31,6 @@ config HEXAGON
> select HAVE_ARCH_TRACEHOOK
> select NEED_SG_DMA_LENGTH
> select NO_IOPORT_MAP
> - select GENERIC_IOMAP
> select GENERIC_IOREMAP
> select GENERIC_SMP_IDLE_THREAD
> select STACKTRACE_SUPPORT

Reviewed-by: Brian Cain <bcain@quicinc.com>

> --
> 2.40.1