Re: [Intel-wired-lan] [PATCH iwl-next v2 3/6] ice: add Tx hang devlink health reporter

Mateusz Polchlopek
2024-07-22T09:23:26Z

On 7/14/2024 4:23 PM, Jakub Kicinski wrote:
> On Fri, 12 Jul 2024 05:32:48 -0400 Mateusz Polchlopek wrote:
>> + err = devlink_health_report(reporter, msg, priv_ctx);
>> + if (err) {
>> + struct ice_pf *pf = devlink_health_reporter_priv(reporter);
>> +
>> + dev_err(ice_pf_to_dev(pf),
>> + "failed to report %s via devlink health, err %d\n",
>> + msg, err);
>
> My knee-jerk reaction is - why not put it in devlink_health_report()?
> Also, I'd rate limit the message.

Hmmm... That's good point. I will talk to the author about that but
seems to be good point Jakub.