From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752343AbcHZEyq (ORCPT ); Fri, 26 Aug 2016 00:54:46 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:32929 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbcHZEyp (ORCPT ); Fri, 26 Aug 2016 00:54:45 -0400 From: Sumit Saxena References: <1471768105-14730-1-git-send-email-christophe.jaillet@wanadoo.fr> In-Reply-To: <1471768105-14730-1-git-send-email-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQGeRB90KT7263niA8YfRf//iGk/caDCFJnw Date: Fri, 26 Aug 2016 09:31:19 +0530 Message-ID: Subject: RE: [PATCH] megaraid_sas: Fix the search of first memory bar To: Christophe JAILLET , kashyap.desai@avagotech.com, sumit.saxena@avagotech.com, uday.lingala@avagotech.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u7Q4soPZ008567 >-----Original Message----- >From: Christophe JAILLET [mailto:christophe.jaillet@wanadoo.fr] >Sent: Sunday, August 21, 2016 1:58 PM >To: kashyap.desai@avagotech.com; sumit.saxena@avagotech.com; >uday.lingala@avagotech.com; jejb@linux.vnet.ibm.com; >martin.petersen@oracle.com >Cc: megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org; linux- >kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe JAILLET >Subject: [PATCH] megaraid_sas: Fix the search of first memory bar > >The 2nd parameter of 'find_first_bit' is the number of bits to search. >In this case, we are passing 'sizeof(unsigned long)' which is likely to be >4. > >It is likely that the number of bits in a long was expected here, so use >BITS_PER_LONG instead. > >Signed-off-by: Christophe JAILLET >--- >Other options are possible: > - 'bar_list' being a 'unsigned long', use __ffs to reduce code verbosity > - PCI_NUM_RESOURCES, which is the maximum number of bits that can be set > by 'pci_select_bars()' >--- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >b/drivers/scsi/megaraid/megaraid_sas_base.c >index c1ed25adb17e..7d3de811d33c 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_base.c >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c >@@ -5036,7 +5036,7 @@ static int megasas_init_fw(struct megasas_instance >*instance) > > /* Find first memory bar */ > bar_list = pci_select_bars(instance->pdev, IORESOURCE_MEM); >- instance->bar = find_first_bit(&bar_list, sizeof(unsigned long)); >+ instance->bar = find_first_bit(&bar_list, BITS_PER_LONG); > if (pci_request_selected_regions(instance->pdev, 1<bar, > "megasas: LSI")) { > dev_printk(KERN_DEBUG, &instance->pdev->dev, "IO memory >region busy!\n"); Acked by: Sumit Saxena >-- >2.7.4 > > >--- >L'absence de virus dans ce courrier électronique a été vérifiée par le >logiciel >antivirus Avast. >https://www.avast.com/antivirus