From: Matthew Sakai <msakai@redhat.com>
To: linux@treblig.org, agk@redhat.com, snitzer@kernel.org,
mpatocka@redhat.com
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dm cache metadata: remove unused struct 'thunk'
Date: Tue, 25 Jun 2024 14:37:24 -0400 [thread overview]
Message-ID: <c08ab47c-944c-7393-d403-e4435cb283dc@redhat.com> (raw)
In-Reply-To: <20240523210550.309116-1-linux@treblig.org>
On 5/23/24 17:05, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'thunk' has been unused since
> commit f177940a8091 ("dm cache metadata: switch to using the new
> cursor api for loading metadata").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Matthew Sakai <msakai@redhat.com>
> ---
> drivers/md/dm-cache-metadata.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
> index 96751cd3d181..0ad9dc1824fa 100644
> --- a/drivers/md/dm-cache-metadata.c
> +++ b/drivers/md/dm-cache-metadata.c
> @@ -1282,15 +1282,6 @@ int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
> return r;
> }
>
> -struct thunk {
> - load_mapping_fn fn;
> - void *context;
> -
> - struct dm_cache_metadata *cmd;
> - bool respect_dirty_flags;
> - bool hints_valid;
> -};
> -
> static bool policy_unchanged(struct dm_cache_metadata *cmd,
> struct dm_cache_policy *policy)
> {
prev parent reply other threads:[~2024-06-25 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 21:05 [PATCH] dm cache metadata: remove unused struct 'thunk' linux
2024-06-08 20:49 ` Dr. David Alan Gilbert
2024-06-25 18:37 ` Matthew Sakai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c08ab47c-944c-7393-d403-e4435cb283dc@redhat.com \
--to=msakai@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox