From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7C1C3FE36C for ; Fri, 27 Mar 2026 17:50:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774633839; cv=fail; b=Pg+2StX+x25GjXvRN4POS/UqXqubnPKMyGdZ4km8KxynflzqClIkhFM3wv1UbvRhgHLGvNwPuf2v4Gx7oXFouMVz8keyWh4Ah7RANH5kdBzVW4rD7wFnaSS4iQETorCWSWKv4oNs1ucTFKhL9G52g8JEG9Ay3QvEuRknBb6jNCg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774633839; c=relaxed/simple; bh=RXa9WPuwrKfNu/hfwbzl+a/sBiFjsHxj9fPdpuEQFIc=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=bUnH8VNhf/beWP4PJ4AJuJMCyR7rMpAyISYzfkhiqqJ6cKm3Z4B767oGw94KTgOLS28w7Sr19arZgZ6BUMXOpTpKwq4jA1qmJLRh4cmmKCsvW0x9cVo7zmIzP7nRAtt1sD5z758RgAka4jShQ6xc2RR9AtgG0JiUTgarVM/CMDc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Brue/6m3; arc=fail smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Brue/6m3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774633838; x=1806169838; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=RXa9WPuwrKfNu/hfwbzl+a/sBiFjsHxj9fPdpuEQFIc=; b=Brue/6m388gSNUUY1HBMJT/2EHXc3rAIvcROH9ya3lhZA3xRoq3Fk9RA hx6mhmK07c2adpJu9GaOIBEZhI3QxQcc9xe3AG7OkwTf1f1f495ozstJH i/YM15gPCnZRWGt6dGqP86wHdpaIp+10D3dVqctcXaP4SbvQvRXtO+WZZ Vl7zLZiwjeAXWD08qwSy3o1gBkhfdV0ALVamO9exDjUVQulTc/JPK3OdM Ptq8RIyX+BqgmVQI77RrmGH1ivBgJX0ffI2p+gRypBRs9X8cUscc6CbLe uh7Nzbf0vdsSoZLUSLnScha6qPiYr+d8Z/iegEUJO/8vcs8D9AMLUYB1y g==; X-CSE-ConnectionGUID: D52VULKsQ661lC+EsHBn0A== X-CSE-MsgGUID: IWIJ/E3BRXCPVp36iSm3MA== X-IronPort-AV: E=McAfee;i="6800,10657,11742"; a="86331982" X-IronPort-AV: E=Sophos;i="6.23,144,1770624000"; d="scan'208";a="86331982" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2026 10:50:38 -0700 X-CSE-ConnectionGUID: cn+DDmKUS4mS+ZQu/18qQA== X-CSE-MsgGUID: pTb4cSxpQP6FgQ/5/kOSKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,144,1770624000"; d="scan'208";a="263333791" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2026 10:50:37 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 27 Mar 2026 10:50:36 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 27 Mar 2026 10:50:36 -0700 Received: from SN4PR2101CU001.outbound.protection.outlook.com (40.93.195.62) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 27 Mar 2026 10:50:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZG3sJkc3p/29GjBLfekKW60d4a5DuFtWWRYO3lZRV3kcLxuWRn2LhYQydXijLfNE09ScvooJHtRNWliIvPN5RKxEROAEqrTChKoasmB3nsGQppzTu2itdD0HZ7slKv6HtO6tfFRL3EBglSCeu2Rl3udvwXpXTAQZh+00F8nJtpB2129rl24mK+vKEkCl/n3nlmJvMOgXUCd6a8fSDPqNCcuWy5Wuc7j9RV4Y25Dd0lZwsINWjNFnyZ3Fgf7OIjUelO4e/aSX+sGLDNWtDQw2ap6v5GstYgLoIOyGJOB0eMHQjWuWSWvvYQDQ00RXu9cweV6ur7Di65MB+63jYI1TsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Iw+29GYYLWTlV3PMPNBDjldNzULNGvyUUd79aupIb9o=; b=A1lA3Kr9CGum3h6Xop6vj1nSXonSmEzDxtPLkHvujar2WhCKm5dNoIMUrH/xdmj3ru+xRsDAF+GMk7vJltwoIHROiDBCuUEhh5qBkAPVJ3sb1BcXnHfm+F/U48ftV6E2T7kCMyeEYuhDmHlVYM1s1YPHL7JyFd1LKy+17nD6nHbtD5oSfOFLVCSYHUlW/rdR84akDJs/EtvDgfqMF8vFD0qPNPpN03djDhF/htwkc+t1H4AP/Mve70W947g0gKQMLCz1VsMX8Bw7r2gtmuwWyH4+mPY3ymK3a6Lq5hwFMktJtVCr3zKE1Chzr49wflkhgHrDoBNZobtAXyeG8jpyzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) by DS4PPFA424F92C2.namprd11.prod.outlook.com (2603:10b6:f:fc02::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.9; Fri, 27 Mar 2026 17:50:33 +0000 Received: from DS0PR11MB7997.namprd11.prod.outlook.com ([fe80::24fa:827f:6c5b:6246]) by DS0PR11MB7997.namprd11.prod.outlook.com ([fe80::24fa:827f:6c5b:6246%4]) with mapi id 15.20.9769.006; Fri, 27 Mar 2026 17:50:33 +0000 Message-ID: Date: Fri, 27 Mar 2026 10:50:29 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 2/4] x86/cpu: Check if feature string is non-zero Content-Language: en-US To: Maciej Wieczor-Retman , , , , , , , , , , , , , , , , , , CC: , References: From: Sohil Mehta In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY3PR04CA0008.namprd04.prod.outlook.com (2603:10b6:a03:217::13) To DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7997:EE_|DS4PPFA424F92C2:EE_ X-MS-Office365-Filtering-Correlation-Id: aaf08fa1-e1ed-42f7-243f-08de8c2957db X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|366016|376014|1800799024|22082099003|56012099003|18002099003|921020; X-Microsoft-Antispam-Message-Info: 3kFfcSRkgUEV3WvaFZtSN42aX/mowDyhGIi+ru0A1nHOqObsnSj09JrDmbudQxbhkaJjltLZB4pIfh9Zf7h0xHdp+4RSMv4DJTlYpi/BRcyzJV3Lc0X4QxJG3TJFbxf4r1bKVv3H/dtVeKzGOZ1PmKB6ym1/xmsdCh0SRUS/vpowUq6ZN+INv9R3/fn4uz/Q4awnDL4KCB6zuRAMzpX0mMWT+aGrPOvTbbzjF8C8gM/HQE8rUBQ4ro5oPk5CXrZtuRF4DNcejVIPUVkVT8i8+V1JRFYoax6ymXzKSSpOcqJTUWNlqCCo3hJls+w0dew+zsrWx9xhsfkaP0w+F1Jct7JDLMeQfIj0MOcSJmHqb2n9X6OSN7rwWj5T8NlwY0bhrzdcrlo+Addrq0y8BndEwG5xqhtz5vih4QfaUOOrVfHn89SAcvMx0PwZK13G/rwnqHbGvXSvDGZtiPxq9f2k4WSk46fW8iWQQsNR2vsAl6TeLxz+dAblW8eAd7NR6C637qlg/pvTLb9JBdc5M/BYXdLTIbCmWhzRIpHahxmUglwP2IsDbiv9NkFsPexoNGYq1Gy7rpHfzIq4G38jOyiIM/bABfOk7lILCZJNwgsAxXNErLHoUhu51b+hViqK6PsXZndFSZNGMINCloJ6+bivRgq+76B6zNeF/EhZgflFCu12MhDtTZ5eUSSYmW/o5cpFOhZiDdwF7hxyuRWyNPRXiT7JXaDpR3qhxecu9HF5J0yuFRpXM/UMG9kIZ3ZeOUu86pX6FwLZG+jD/1s5WhTRLQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB7997.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(366016)(376014)(1800799024)(22082099003)(56012099003)(18002099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TExycTNqQU9ocjd3VFpRbVlQN0VFUVFIQ0VXTldoQThRTTA1SEc1N3VpekJr?= =?utf-8?B?dVVnWmJnS1d3aVp6UWFYR2tyb042Z1JudFdUdmxHWXdVUVhiTDVLcC9YSEF2?= =?utf-8?B?THlkdFQ1Zlp1Rk9CeVc4TGNrLzNOU1hUTktpRXk5dHRzb3UrKzA4OVZTR0l4?= =?utf-8?B?WkhNTGMrNmlUemxQYlc2Qi9jSGllVmpBbHA5QlJuNWpBQlM1UEdhWVJPZWdo?= =?utf-8?B?dlVsb2UvUlFjMzhJMExyS2dRdnFDNDRqbTNDSDREUHdGQnVXQ0pnaDNCbUxr?= =?utf-8?B?akkrZjZUODRGTWVkTDJEWkVWL0lCeC82WE9jSmxJSUkyR3hXMlpQZlB2M0Ix?= =?utf-8?B?dXh0WmFSQmphOXE0MzFGcHV5Q2NSNTBaYStZb01VWmF6VmtkZVp1V0JDVzlF?= =?utf-8?B?bmFFQzk5dkpkaGtDNGZFaWtYTVFSZkw3T2pEdUR3OU1XTXZTbDZ5R3VZY3VL?= =?utf-8?B?VGNFaENlVXNLTFhjak12N0J4TURnSWZRWFVpRmpYd0IyRWJ3aDluSVpwYThI?= =?utf-8?B?cndtY0Nvb253eFREcWFUUlhrYis3WFE0M3NhY0g4RmpOUjJPeCtvalZYZFpX?= =?utf-8?B?M2FHcnF0MnZvUUdqTG0vSXV5TjU3L1RLV2Z0Nmx2SGpvR1dmNFVEd0p0NUtq?= =?utf-8?B?ZnpQSmh0QmtmWE5IeFp0WVRJUVMyclJFaDNNSDV4cFpMcmc1UEdVRXJKbVBB?= =?utf-8?B?c3RMNkJKdGNHd0s5SGo5WEtDY2Z3SGxxNHZRNlJPVllyRWNKVTJWVzI3Tmlz?= =?utf-8?B?ZFlRd1lmaDBlSUduZTBXRHZhUk9pYzZMcXAyaCtPWnNnOEdvM2oyQTQ3RUZx?= =?utf-8?B?OUlZcUJkQXBiZUJ3VlhnWnhsVWFNQlY5MVowVDNOVmVYRGIremhkeEpTTWEz?= =?utf-8?B?NVp1L2FYMVdlaVQ4emdReFA0VVJING9HQmRxazVZaVhaTkVGRVo5SDUrOGVl?= =?utf-8?B?ckxXMExNSHZhOTVETE5kMGQvMjBEZTBUL1dPUEloWmFBYU52Uk1tK3UwQ0ho?= =?utf-8?B?L3ZxVTVpc3d4M2xQZzZtQjlXUzYxYVlyYmpYNE5QTlZJZXdwREJsOFJQSkpQ?= =?utf-8?B?b3BGVEVTRHhWM0puSm1TRFpydUl5Z25xekZTcWI2aGlXeTBrem9mRTdsYlFP?= =?utf-8?B?TVU0bEdTZWlHTGJnK2JyVGluZk9VUEU4aXNRbk9sYXIvWGxZK01rUE9zMmJD?= =?utf-8?B?d2VFNnpBcS9xZDVoVW1GZXdJZGd5Qk1McjUyYjZReERJNlhCWjZTcjJvc2Iz?= =?utf-8?B?WVZBNGpZSFVudXB5MHhieVlyUFl1YkUvYVBlVUREclQ1Y3BMek45cmZwTjNB?= =?utf-8?B?M3hpbDVTL2xxM3BzeXlGb3ZXeGpib0d5ektmdHRaWkJwS1FEUkpsMjNDakxO?= =?utf-8?B?QVY0SHhwMFdraTcycWdsTGZ5TTEzaURWdCtkcmk3V1hJQVQzdS9vYzA2d25r?= =?utf-8?B?cHNoVE1XNElpZ0dVS3ZaRzBNMy9aVDhNSVVuMnFnVGIyalNQOFg2MmVKVFAr?= =?utf-8?B?dE9uaW8vVEh0RlJFbzlXRVQxT2xPUlVyWkFUaENVUEdWd1Z1bWFwNndPOGtk?= =?utf-8?B?L2EvTlZxeFl6ZlJ3bnVSY1ZLQXc2MWxOUERJaTNPZDIya1lmQjkvU25pcmVl?= =?utf-8?B?dUprc1EzN1hiUDl1VFhZdkxMcnVCQzdyekROTE5MRGYzUVErU1R4aGdOZ1VJ?= =?utf-8?B?L3hPaDRYRDVvSmprTWQrZUduSU9GaTF4MEZraWd4aU90N3dqdjB1SlkvY1BK?= =?utf-8?B?NmFlMDkyWFFWbEFjRHFsTjJveDlzN2pIbGo4NGlQU1haYWpHcW9HWGk4YUVO?= =?utf-8?B?S3RodjM1ejF4aUZ1WW5NUEdCSkwyWlB1UUYycVQ4bktyQnhrejVWeGowbHZN?= =?utf-8?B?ZzYxVWtYRHRQalMvbW9mNk9LdFYvTFc4NDI3V2JvRkRYdm5WNFlVa1NzUGUw?= =?utf-8?B?NEhVZ0NWRmVLUjFXVmM4MDZ2ZytxSG5Sa0orKzFycW9RZEdaaDNjbUZtb29E?= =?utf-8?B?T04rNG1vdjdubWVJTWlNVHBxdjcxTU9VK0FXMGJWY2xwbHFNVkp0ZVpvZVkx?= =?utf-8?B?bFlIVmJYbzJPS0MxLzR4SWg1blVRNzB1KytGMnBnQ2ErZ2thcGRhZWtsY2Zs?= =?utf-8?B?VzFhT3lzUUZMWmdISTdrbksrRHg3eXpSeklDMjVqc1FscnNzeWhVYTV5UVFI?= =?utf-8?B?dlRFUzhobFU1azJCY0QyY1c4U254TDFKWUI2MElnbXgrc2hMUWxpNEhHZnpB?= =?utf-8?B?c1ZZTjZwVGRVRHBRcVFmQTF2WWNHWStCa2JtZCtiTW5OSEJtZFA4M0VyN3J5?= =?utf-8?B?ZDNaTHMvdkQxTElRcDRSd3luZk9MMzRpNFBFRDlCeUZGMDdjRFZOZz09?= X-Exchange-RoutingPolicyChecked: VjRgXupTGCgf2qgFDcI0uTitIh/7yb6H9MCBS0murJpGMrcWQQkwa0Mc2XiTrQoEXeyWtqf1JgUeRvSixYrPvvYgTK1jgRyXC+a7HpqSpMJogcbQmVfw2E2BRm4KPSGV48gfPCTOp1TrlBfU0D8xz+y6+FZF4mXxCC9snQw0JViPuzy9nWr3J0NhkhWuQB2N4L2DGoqMuu8p9VU8Gf8M/RSDCEYqOi18OJa0h0E25mRm6WWbWbGoQaNJEqtT/Gq+VOaPjm1g5ZM+zqyWLtPE3Pr/v3n/MKN57/RGEutU0UqW52+6q8aCjyRX9vAs9Ri0QY/GHLVw0L5zvJVNPJmuXg== X-MS-Exchange-CrossTenant-Network-Message-Id: aaf08fa1-e1ed-42f7-243f-08de8c2957db X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 17:50:33.0958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +vXHvnh0EZq6u5BiViv3xcZMwlb5XRpfjYCmy7142QZXxCXyi8PvboVDb9OxnUldaeZ27Xuz2Nq4wmZFUEfWyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPFA424F92C2 X-OriginatorOrg: intel.com On 3/27/2026 8:10 AM, Maciej Wieczor-Retman wrote: > arch/x86/kernel/cpu/common.c | 30 +++++++++++++++++++++++++----- > arch/x86/kernel/cpu/cpu.h | 4 ++++ > arch/x86/kernel/cpu/cpuid-deps.c | 19 +++---------------- > 3 files changed, 32 insertions(+), 21 deletions(-) > Reviewed-by: Sohil Mehta A couple of minor points below: > @@ -1637,6 +1638,7 @@ static inline bool parse_set_clear_cpuid(char *arg, bool set) > > while (arg) { > bool found __maybe_unused = false; > + char name_buf[X86_NAMELESS_FEAT_BUFLEN]; > unsigned int bit; > > opt = strsep(&arg, ","); > @@ -1657,10 +1659,7 @@ static inline bool parse_set_clear_cpuid(char *arg, bool set) > setup_clear_cpu_cap(bit); > } > /* empty-string, i.e., ""-defined feature flags */ Can you delete this comment as well. It doesn't make sense now. > - if (!x86_cap_flags[bit]) > - pr_cont(" %d:%d\n", bit >> 5, bit & 31); > - else > - pr_cont(" %s\n", x86_cap_flags[bit]); > + pr_cont(" %s\n", x86_feature_name(bit, name_buf)); All the other equivalent buffers are defined as feature_buf, but this one is named as name_buf. Just curious, any specific reason? > > taint++; > }