Re: [Xen-devel] Re: [PATCH 3/5] x86/pvclock: add vsyscall implementation

Avi Kivity
2009-10-13T06:41:15Z

On 10/12/2009 09:13 PM, Jeremy Fitzhardinge wrote:
> On 10/12/09 11:29, Avi Kivity wrote:
>
>> Good catch. Doesn't that invalidate rdtscp based vgettimeofday on
>> non-virt as well (assuming p == cpu)?
>>
> The tsc clocksource assumes the tsc is (mostly?) synced; it doesn't use
> rdtscp or make any attempt at per-cpu corrections.
>

So it's broken or disabled when that assumption is wrong? We could
easily fix that now. Might even reuse the pvclock structures.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.