From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: Chengyang Fan <cy.fan@huawei.com>
Cc: guohanjun@huawei.com, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] resource: Remove unneeded semicolon
Date: Tue, 19 Jan 2021 15:32:32 +0100 [thread overview]
Message-ID: <c0bc7da5-feec-dbcd-6fdd-e0bea359572d@intel.com> (raw)
In-Reply-To: <20210118015000.2599677-1-cy.fan@huawei.com>
On 1/18/2021 2:50 AM, Chengyang Fan wrote:
> Remove a superfluous semicolon after function definition.
>
> Signed-off-by: Chengyang Fan <cy.fan@huawei.com>
> ---
> include/linux/ioport.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index fe48b7840665..803c10f6a6df 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -337,7 +337,7 @@ static inline void irqresource_disabled(struct resource *res, u32 irq)
> #ifdef CONFIG_IO_STRICT_DEVMEM
> void revoke_devmem(struct resource *res);
> #else
> -static inline void revoke_devmem(struct resource *res) { };
> +static inline void revoke_devmem(struct resource *res) { }
> #endif
>
> #endif /* __ASSEMBLY__ */
The patch is fine AFAICS, so
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
but I'm not sure why it has been sent to me.
It would be better to send it to Greg instead.
Thanks!
prev parent reply other threads:[~2021-01-19 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 1:50 [PATCH] resource: Remove unneeded semicolon Chengyang Fan
2021-01-19 14:32 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0bc7da5-feec-dbcd-6fdd-e0bea359572d@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=cy.fan@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox