public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
	"Zhang, Tina" <tina.zhang@intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Michael Shavit <mshavit@google.com>
Cc: baolu.lu@linux.intel.com,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] iommu: Call helper function to get assigned pasid value
Date: Wed, 9 Aug 2023 18:58:15 +0800	[thread overview]
Message-ID: <c0e94e88-94b8-69de-69c8-ed132ae28951@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB52767F29A6C11157659D375B8C12A@BN9PR11MB5276.namprd11.prod.outlook.com>

On 2023/8/9 17:49, Tian, Kevin wrote:
>> From: Baolu Lu <baolu.lu@linux.intel.com>
>> Sent: Wednesday, August 9, 2023 8:22 AM
>>
>> On 2023/8/8 15:49, Tina Zhang wrote:
>>> Use the helper function mm_get_pasid() to get the mm assigned pasid
>>> value.
>>
>> For internal iommu drivers, perhaps we should use another helper.
>> Something like sva_domain_get_pasid()?
>>
>> Suppose that the iommu drivers should have no idea about the "mm".
>>
> 
> Aren't all touched functions accept a struct mm_struct pointer?

In the end we should remove all mm reference in the individual drivers.
The drivers only need to know what they need to know. All mm-aware code
should eventually be moved to the core.

For now, at least we should avoid using mm in the set/remove_dev_pasid
code path. Later, once we complete consolidating mm notification in the
core, drivers will have no need to use "mm" anymore.

Best regards,
baolu

  reply	other threads:[~2023-08-09 10:58 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  7:49 [PATCH 0/5] Share sva domains with all devices bound to a mm Tina Zhang
2023-08-08  7:49 ` [PATCH 1/5] iommu: Add mm_get_pasid() helper function Tina Zhang
2023-08-08 15:02   ` Jason Gunthorpe
2023-08-09  0:31     ` Baolu Lu
2023-08-09  9:47     ` Tian, Kevin
2023-08-09 12:31       ` Jason Gunthorpe
2023-08-08  7:49 ` [PATCH 2/5] iommu: Call helper function to get assigned pasid value Tina Zhang
2023-08-09  0:21   ` Baolu Lu
2023-08-09  9:49     ` Tian, Kevin
2023-08-09 10:58       ` Baolu Lu [this message]
2023-08-09 14:48         ` Jason Gunthorpe
2023-08-10  1:37           ` Baolu Lu
2023-08-10 16:30             ` Jason Gunthorpe
2023-08-09 12:35       ` Jason Gunthorpe
2023-08-10  7:52         ` Tian, Kevin
2023-08-10 16:36           ` Jason Gunthorpe
2023-08-11  3:18             ` Tian, Kevin
2023-08-08  7:49 ` [PATCH 3/5] mm: Add structure to keep sva information Tina Zhang
2023-08-08  7:49 ` [PATCH 4/5] iommu: Support mm PASID 1:n with sva domains Tina Zhang
2023-08-08 15:12   ` Jason Gunthorpe
2023-08-08 15:19     ` Jason Gunthorpe
2023-08-10  2:14       ` Tina Zhang
2023-08-08  7:49 ` [PATCH 5/5] mm: Deprecate pasid field Tina Zhang
2023-08-09  0:18 ` [PATCH 0/5] Share sva domains with all devices bound to a mm Baolu Lu
2023-08-09  9:44   ` Tian, Kevin
2023-08-09 10:51     ` Baolu Lu
2023-08-11  1:06       ` Tina Zhang
2023-08-09 14:46   ` Jason Gunthorpe
2023-08-10  1:23     ` Baolu Lu
2023-08-10  7:44       ` Tian, Kevin
2023-08-09  9:41 ` Tian, Kevin
2023-08-10  1:31   ` Tina Zhang
2023-08-10  7:49     ` Tian, Kevin
2023-08-10 16:27       ` Jason Gunthorpe
2023-08-11  1:12         ` Tina Zhang
2023-08-11  1:07       ` Tina Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0e94e88-94b8-69de-69c8-ed132ae28951@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mshavit@google.com \
    --cc=tina.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox