From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>,
alsa-devel@alsa-project.org
Cc: cezary.rojewski@intel.com, kai.vehmanen@linux.intel.com,
mac.chiang@intel.com, lance.hou@intel.com, broonie@kernel.org,
brent.lu@intel.com, bard.liao@intel.com,
liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com,
perex@perex.cz, linux-kernel@vger.kernel.org,
mark_hsieh@wistron.com
Subject: Re: [PATCH] [v2] ASoC: Intel: sof_rt5682: Add support for max98390 speaker amp
Date: Tue, 24 Aug 2021 11:22:09 -0500 [thread overview]
Message-ID: <c0e98e24-1c62-aa37-e283-c8b5f56f4f2e@linux.intel.com> (raw)
In-Reply-To: <20210824132109.1392-1-mark_hsieh@wistron.corp-partner.google.com>
Looks mostly good, minor comments below
On 8/24/21 8:21 AM, Mark Hsieh wrote:
> Configure adl_max98390_rt5682 to support the rt5682 headset codec and max98390 speaker
>
> BUG=b:191811888
> TEST=emerge-brya chromeos-kernel-5_10
I don't think we need this for upstream?
> +struct snd_soc_ops max_98390_ops = {
> + .hw_params = max_98390_hw_params,
> +};
this could be const. We didn't do it for previous codecs but that was a
miss. I'll send a patch for the max98373
> +extern struct snd_soc_ops max_98390_ops;
const
prev parent reply other threads:[~2021-08-24 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 13:21 [PATCH] [v2] ASoC: Intel: sof_rt5682: Add support for max98390 speaker amp Mark Hsieh
2021-08-24 13:59 ` Cezary Rojewski
2021-08-24 15:32 ` Mark Brown
2021-08-24 16:22 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0e98e24-1c62-aa37-e283-c8b5f56f4f2e@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lance.hou@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=mark_hsieh@wistron.com \
--cc=mark_hsieh@wistron.corp-partner.google.com \
--cc=perex@perex.cz \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox