From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755000AbdLUQKW (ORCPT ); Thu, 21 Dec 2017 11:10:22 -0500 Received: from mail-sn1nam01on0050.outbound.protection.outlook.com ([104.47.32.50]:5120 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751143AbdLUQJ4 (ORCPT ); Thu, 21 Dec 2017 11:09:56 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, bp@alien8.de, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , =?UTF-8?B?UmFkaW0gS3LDhMKNbcODwqHDhQ==?= =?UTF-8?B?4oSi?= , Joerg Roedel , Borislav Petkov , Tom Lendacky , Herbert Xu , "David S . Miller" , Gary Hook , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v9 00/38] x86: Secure Encrypted Virtualization (AMD) To: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org References: <20171205010438.5773-1-brijesh.singh@amd.com> <51fe0851-14d7-cb37-613c-0eaf8a7d2a65@amd.com> From: Brijesh Singh Message-ID: Date: Thu, 21 Dec 2017 10:09:44 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <51fe0851-14d7-cb37-613c-0eaf8a7d2a65@amd.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: MWHPR10CA0072.namprd10.prod.outlook.com (10.169.238.34) To CY1PR12MB0149.namprd12.prod.outlook.com (10.161.173.19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ed719dce-177c-4b32-59a5-08d5488d44f2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060);SRVR:CY1PR12MB0149; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0149;3:7T+PEoBuU4q4TS4yrT+IE547oJKW5q5NVRjUYHjlL7MQcjVuZWyZFBtpCeHyg1bL44QFxs9RuJJhd0o1xDE9P8kepsMUbj8cwArAqVo/yQReRN/6avyIB4II7nSbf70DBvNLT3s5DCliVIWBt0g8ajnVJlXjDv5Dp50UmSPacTk0w9u/nIPKFfhTImgJ8vPcbEQHPzHN0s8sXHxdKhSNTG9JanAzLd+dVW8nDwHsGhkxwsTOih2lJl6dzsnCJyZf;25:glzXYFdnSiCVUMiO1izFjA9SEvEplFzwEs369AkX7//NTvuBAHg8lE/zC2x6WxRhErGRjMds6CjqzEOpqlE9KBmhSQrivPuEbS+4iZCV4BLM8YityJdBvSi1gfkrVKJCSHd9xWk5f5XlmBIQWHpGG1Ntrc9S66l25qNoEge5iazr2aAonu8larPN7KESH8QFkbMQqLYrC8nnD6Buk+aXntPP0TSuqEAvKU+rr+0yliAwYHRLWJmlArKHV+gz47wDnLwbTifJFU3PtvycCqDijwhGUimIhvhm/pM0Osj17sPfWeS5Pwc65vNsEKFYuMpJzFF4B3NlnYLsCtUpB/1NdVN4xSrTbmU40yfbEtXaQnM=;31:b53/hB7YoveShVMMnZlJQdfcdRJlbavQSQOfFPIklIbth1qKY0IZJFhu83IRLhisl2vARt8eQWs1HN5YvXED1X1DQiJO2/6MBpktrGGhtvLILPCTmJ6k03RUDg0nfYraknwQBTg/pTp998/vcxFMcmXc6szYE8g8EC8RzGOwviNCnbgJIkJKK/fi18tcFzFOw2bIIcJR58AvR84LtmJzT7PJcRyOeiYWVpPTiV2DGXU= X-MS-TrafficTypeDiagnostic: CY1PR12MB0149: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0149;20:Z+v1j475vf6JrMOI63cIfdk+VTXyX8R/VTbHd0slUCPN9qu+zhLxVqr/seCu5+BPFmaDL4x9SHZiyU9zXxXrMcDXJt7ATUx+ZBSmVrEjoSriYAsvU8ek7hcLaVRfOq+ahWyLEBgvEZCsPLM2+0bNbC2ZQG0PnfKXu3e+gELtVA6p5uayVbEXlhxDTRYnpUABgCMz2DGkYy6vQxiotMYww3zcoEncejjRKtoA+XZC7e3pkSyZEpjRh0jANXkBLgAR4lFDuWrIJYwJZ5tNQCP57FoF0GYRLuYHs8HG09zPfB6o/kS8qgdlgxntTimulEDcZVzPeOTIQhLmYEiP1lfMdZDSsR7sF6KlcR4DPSsmvedfbUm3XjY4SVWAYdsRmEiCJUv0yRgp49pvdPlIbjKv2T0cIPMLosBcrA3Vk0FKCrX4UByuNwAsp4F82sUl468rxU8ZIvW9AtZDrvWhoEZpoApPZg7dYskbOlzpTCBg1zA3Ewtz+z0Lq6avgLKEapgZ;4:QEtaviIf2t8sRrVhowCOcDKAH/jIcuge2iRg6iCthiCCgNipI1/ilqF7ytkeeWQaljtMBNxMBhykE7guV2x4hIIBpopQZUXJqp2uG1A7vlE0dAbDZpqjZJvfg1bPK6LQfCuEd2tmqsrEgQYi0u4AVNxBxQpaFEHPWdt9oc8+GTXxG8nZQE+KeDjtxv3+cOjr7BlOHTxOOaFYKLGCbw5r9aIy4wRHbpb/NeTdb/aQWdcY58+FseV+/qyAoiSyRNizdnPKXcaauJ3OlKNHEEWNzA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231023)(6055026)(6041268)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:CY1PR12MB0149;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR12MB0149; X-Forefront-PRVS: 0528942FD8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(396003)(346002)(376002)(366004)(39380400002)(39860400002)(24454002)(189003)(199004)(16526018)(54906003)(58126008)(386003)(81166006)(31686004)(7416002)(53546011)(68736007)(6506007)(2870700001)(8936002)(53936002)(66066001)(4326008)(50466002)(65826007)(83506002)(5660300001)(65956001)(65806001)(6246003)(8676002)(105586002)(106356001)(316002)(36756003)(6666003)(229853002)(47776003)(6116002)(25786009)(3846002)(64126003)(6512007)(2906002)(23676004)(52146003)(97736004)(2486003)(2950100002)(31696002)(7736002)(52116002)(76176011)(478600001)(81156014)(86362001)(6486002)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0149;H:Brijeshs-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTQ5OzIzOmlhSnFES1orVmRKWG9MaEdyLzhaVy9nbXV1?= =?utf-8?B?RmR1VjlBb21ndkdGamdaOFZXNjF6bDVjbmN1RGFkbTVWQXEvSE5kbWRkcWE3?= =?utf-8?B?QjBRSFBoaWdYN0xWbWRxNGJRWWpqeE1pbE9SNFlYU1hOQW8yamNMOEpSME9t?= =?utf-8?B?b2lnTEQ2OEF3K2lNNUxpcldRK3htaTlPZjg5NlV0MEhoWkQyeW9kT0NJZjFx?= =?utf-8?B?SCtnRW9iR0tCNUJxZ2JLTlppc1NyTFhyRTZySW1Ua0Nsdm00V0Q3ZjFyZEZ3?= =?utf-8?B?MnZFeGpCcmtZdFhwKzR0V0p0aHhYRjBnY3ZZVDNLNER5bFlSd1pMdVlEVERm?= =?utf-8?B?SURrTTdGMmVaOWEyb2ZNTXQ4MklhSTUvb1hGYjlKclJuK2lVdkV0Vnc4cU8x?= =?utf-8?B?Nlg1WjcrMGdXb2c4MFJoeWV1QkJZZXlDT0dWN09ObFB1SE9nc09yWXZHTmVp?= =?utf-8?B?aTl5MjBxdklxOXZCYnlzcFN2cVFGUjIwQjlqd2JJLzBQUGhDZVY3RW5lNk9G?= =?utf-8?B?SGtlcmpMb3BaSTlQOU9BQTNCYm4zUlJCb0cyVC9PWGhiU01KejIyZWUyZzhv?= =?utf-8?B?alllSUlkMk5YOEdsL0w0ZWxScXU1c1JYaStQS1I0d1hNbGdTZjVFeFhvbDcx?= =?utf-8?B?c1pLY0tuOW83L1Yxc0k5eDNyS1lIYmRBdFhDeXhob3FhRUNFMXkrdmovOSth?= =?utf-8?B?WU4zNTRVYXp4ZGZmbDQ5aUFGOU0yWjJhL0R5ZGxuL0dETUEvN1FoSGt5dW1X?= =?utf-8?B?OS8rWHVjWkdTWUhKTFg5ekRYcDlRV1o3d1NQR1JiRVNIZ1NNUEJpSXpxWWFV?= =?utf-8?B?elJOV0tLVHB3YVI4RnBDSHEyL1ZvN3VIL2I2bjFWYzNPeE84cmM4SFQ0aVRB?= =?utf-8?B?Rzd2MGd0MlJPZFJhcWlISEROQ0Vwd1pxVFBQVFFBbUR5QkM5dHFOaW5IUFA3?= =?utf-8?B?TnVjNmQzTHhsUVBLcnNRc3JWZkU3KzR3U1Q2VlBvY2xpYVlWNXJ3M3hVRzAz?= =?utf-8?B?QVIxOWhWWlBsREVFNUhDWGR3dVRySXVqK1FEVTZ5alZCcWJDYVdld3BXZVd2?= =?utf-8?B?R1N1VzIrSVgxN3pkYzFWMlpGY3VmdmNUWFNSMGxmTnRxTmQ4WUNTODJMSmpS?= =?utf-8?B?U3ZrYmN6R3huenI4TlZTczU3WW1aQ204cmZwKy9wd3dJTjJNYkdMcGYyTk9L?= =?utf-8?B?eHhhWTVsNzJMWmZ1cXRuWG15MFk2SjNnYmNCT04yVjl6WXFHbEZESnpqYkRP?= =?utf-8?B?aG51aDlERU9lejk4YTBEdFpZTG9IZ1dWWTlQQWpTQ29LOVJkMnFYQlE4RnBl?= =?utf-8?B?b0NuYlc4c2Z5Wm8xNHNZTmd3Uys4NmpNaU9EbDIrNTFnYUQ3VlhNV1Z4UG9s?= =?utf-8?B?VGdxRXpvWEJ1c1lobmtXV21uSW1Nc1crVmZxWU9aU2M5NWtJcCtNNWZVYklN?= =?utf-8?B?NzhUdEs2cWtMRFFWTEdBbUtiQ3UvNzhieFNhb0M5enJQWE1qaFNSLzJGRDFq?= =?utf-8?B?RmZ3UEI0QzJvcllBK2IzOHlFYis4QjRwWGp5WTdZZFE3ZkkyZ0RTYTYwZjU2?= =?utf-8?B?eVZtaWJXN2FuZ2ZmTmRxb0FTcVpWclJTUjVidCtFT0xHZFJwMFRDalNuV0lr?= =?utf-8?B?L250QStoM0ZzUUJiNHB5clgyaWpuNWZDS05VcnE1MkRCUGduRWVsZWxqNEhB?= =?utf-8?B?TVl5dWFESVNFTkc0c0swTjhIeG9UQ2Y0dXBlYy9RLzVzOGdKRERjLzQ2ZnBp?= =?utf-8?B?S2ZtRURpQ3doZ2M2WlFVTXM0Q1JZYk5HTm5ZMGRjb0NmdjZoNkVRTjh0bU00?= =?utf-8?B?ZWJSZGhpVjFDRnM2dnVSZ2Q1WU1xWWRnV0QvWUtKVE9rRVE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0149;6:04a3U5ZQ8ilk+NQW5g/LtFOJL7trUMLlasBZ9FPgx3Pv7fMhol198t3HNXjvXCV6jEsDkJ4neMnncGgH0nDVv0taTJcCDC/V1vxQdQZTAp5bTv99dM1w3Bj0hno8z1G7gkPkBRSMJ9m1/uWBNWv0HZCnqIElW8j+4cHWvV0aZQjDc0inEQz0RckQgO5+8yTvBZo5m8Y74st+4qnclfFp9fCMV+1DiTPRhEIyCmuMtW/ZB4GzM+i01hJ0WKHWB4IDStDqCLfwKC+ZFwrhyScAUsaGIiPm0JmCHOrI3iXvSbxvQcERliF03U/Zl0tr1cXhq5NH3VFBU92zGuwq/drRUbOKU3Bn0iFMPM3PW4akmGI=;5:sx3EHXyqiwDl5KiPpsPk29eBwohZhXSHft/mJqfVDID913bieI1RnakYoD1biFrtuQe3/x6xcxLDg/ZJpyfOmfvRKsnV9gWJdX51LHLgnpylSHExOHiYd4RRv/2C/SbpU53Yff0EAoUmG5GXnz3zxeUaEumOw6/etBAxRABKA0E=;24:blRxXlzaljXGnQ54qcbfIBujEHqXVuKZSpOue8uZ3cewO5rvHBmsGmknC7YlsJHpGWodjbA+8FPlzNdgZfuK63+ygH4ROGJbMUXf4WjeabE=;7:F3//fbx6JQdSLc6IgTvjpe17pGaz3RS9mO0hqSHM46hojPp0qvY8GzEY/y2+aAB6+s2I1VzV9k8lrrbQPP6BJeYJVd0UOd9kPeo0AJZDJSi8Uy9ZjU78U2UjL+SlPsRNnKFZgur6spZRGI85HBlOvTXNN2Wmdr/rYa6qsvhHlfXVbvC7Fys7vaMYKLZ02smkS/77ei9QlmHGY3sySe659jWQSNDFVkC79JsNHUUBL+4OUktIfxBgWIxmwYWGaDhk SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0149;20:pgyPuvF+vtzGu4RtW54x9Zr07nCurowTi8Z9vdSVQVJsDKOsdFFH24GJ5a0bweIAjcZBkuhCaVAsQmk6O2j/8rp9V3uPIHWdyQU8euk8oINXBnI9o1QPTn8X66SaFHOEFEqEbxZm4BvEZIv1PljKulVoxGYXIqRBf7iO1I+XH/FPlLFt7qlqzVjuw6na3FJOV2FIIIkSz9+DbV5BGv2wjz/VIAkqYX4Tf7zny/TgugdDy3RRxnO7nN10sAGjfhSO X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2017 16:09:50.7116 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed719dce-177c-4b32-59a5-08d5488d44f2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0149 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/21/17 9:51 AM, Brijesh Singh wrote: > > On 12/21/17 7:06 AM, Paolo Bonzini wrote: > .... > > Hi Paolo, >   > >> Hi Brijesh, >> >> I have a couple comments: >> >> 1) how is MSR_AMD64_SEV's value passed to the guest, and where is it in >> the manual? > It is a non interceptable read-only MSR set by the HW when SEV feature > is enabled in VMRUN instruction. I just checked both PPR and Family 17 manual and it seems both are still missing this MSR definition. I will ping doc team to get it updated. thanks >> 2) ECX should be 0 in the guest's 0x8000_001f leaf, because we don't >> support nested SEV guests. Likewise, EAX bit 2 should be 0 since you >> don't emulate the page flush MSR. > IIRC, I do clear both EAX Page_Flush and nested virtualization case from > Qemu SEV feature is enabled. >> Both can be fixed on top (and I can do the second myself of course), so >> there should be no need for a v10. > Thanks >