From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Raul Rangel <rrangel@chromium.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-usb@vger.kernel.org,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()
Date: Thu, 2 May 2019 15:17:17 +0300 [thread overview]
Message-ID: <c102196e-1250-307f-0b2e-d76c62a161a0@linux.intel.com> (raw)
In-Reply-To: <20190429200541.GA116440@google.com>
On 29.4.2019 23.05, Raul Rangel wrote:
> On Thu, Feb 07, 2019 at 05:48:16PM -0800, Andrey Smirnov wrote:
>> Xhci_handshake() implements the algorithm already captured by
>> readl_poll_timeout_atomic(). Convert the former to use the latter to
>> avoid repetition.
>>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Tested-by: Raul E Rangel <rrangel@chromium.org>
> Reviewed-by: Raul E Rangel <rrangel@chromium.org>
>
> This fixes a bug on the AMD Stoneyridge platform. usleep(1) sometimes
> takes over 10ms. This means a 5 second timeout can easily take over 15
> seconds which will trigger the watchdog and reboot the system.
>
> Thanks for the patch.
Adding to queue
-Mathias
prev parent reply other threads:[~2019-05-02 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 1:48 [PATCH v2] xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic() Andrey Smirnov
2019-04-29 20:05 ` Raul Rangel
2019-05-02 12:17 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c102196e-1250-307f-0b2e-d76c62a161a0@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=andrew.smirnov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox