linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yannis Aribaud" <bugs@d6bell.net>
To: "Eric Wheeler" <bcache@lists.ewheeler.net>,
	"Johannes Thumshirn" <jthumshirn@suse.de>
Cc: linux-bcache@vger.kernel.org,
	"Kent Overstreet" <kent.overstreet@gmail.com>,
	linux-kernel@vger.kernel.org, vojtech@suse.com
Subject: Re: bcache_writeback: bch_writeback_thread...blk_queue_bio IO hang [was BUG: soft lockup]
Date: Tue, 02 Feb 2016 07:58:24 +0000	[thread overview]
Message-ID: <c110be9e2bccb346cf07c76f29a95a06@rcube.hebserv.net> (raw)
In-Reply-To: <alpine.LRH.2.11.1602011108460.21204@mail.ewheeler.net>

Hi,

1 février 2016 20:42 "Eric Wheeler" <bcache@lists.ewheeler.net> a écrit:
> [ changed subject, more below ]

> Are you using md-based raid5/raid6?

Not at all. In my setup Bcache is used on two bare drives (HDD and SSD) 
behing a hardware RAID controller (disks configured in non-RAID mode).

> 
> If so, it could be the raid_partial_stripes_expensive bug.
> 
> If it *is* the bcache optimizations around partial_stripes_expensive, then
> please try the patch below and then do this *before* loading the bcache
> module (or at least before registering the bcache backing volume):
> echo 0 > /sys/block/BLK/queue/limits/raid_partial_stripes_expensive
> where BLK is your backing volume.
> 
> I wrote this patch because we use hardware RAID5/6 and wanted to get the
> partial_stripes_expensive optimizations on by setting
> raid_partial_stripes_expensive=1 and io_opt=our_stride_width.
> Unfortunately it caused the backtrace in the LKML thread below, so we
> stopped using it.
> 
> See also this thread, however, it shows a backtrace prior to
> removing the bio splitting code:
> https://lkml.org/lkml/2016/1/7/844

I'll take a look.

> Note that commit 749b61dab30736eb95b1ee23738cae90973d4fc3 might not
> exactly address this issue, but it might prevent full hangs. Make sure
> you cherry-pick commit 749b61dab30736eb95b1ee23738cae90973d4fc3 and
> hand-clean-up as necessary. It simplifies the bio code and deletes a bunch
> of stuff. It showed up in 4.4 and isn't in my patchset.
> 
> After commit the commit above and setting
> raid_partial_stripes_expensive=1
> we still get errors like this:
> bcache: bch_count_io_errors() dm-3: IO error on writing data to cache,
> recovering but they don't lock up the system. Ultimately we run with
> raid_partial_stripes_expensive=0 because of these related problemsand
> haven't had any issues. Also, fwiw, we run 4.1.y as our stable branch
> backed by hardware raid.

I'll give a try if find some time to do so.

Thks.
-- 
Open is better

      reply	other threads:[~2016-02-02  8:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 19:42 bcache_writeback: bch_writeback_thread...blk_queue_bio IO hang [was BUG: soft lockup] Eric Wheeler
2016-02-02  7:58 ` Yannis Aribaud [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c110be9e2bccb346cf07c76f29a95a06@rcube.hebserv.net \
    --to=bugs@d6bell.net \
    --cc=bcache@lists.ewheeler.net \
    --cc=jthumshirn@suse.de \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).