From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A1B842B325; Tue, 7 Jul 2026 14:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783432822; cv=none; b=pBkO8Cvi9qInmhwqndfjGbsXxRgV0iXDvkHg2t5j/AjoGT5JlUIa/0oSPLLGdv9QZhjVunQbA9DYoXGlRUCK6FZ6Dh151+wXKtNg64w2bCujxa9lzCAdI3aWBY2SGNqgh6Mu559Orkd/qmwR6lxb74J3+qRLJ5AIxbgoJGNiykU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783432822; c=relaxed/simple; bh=hTF38CRsldNCAc84C+24BLtsxFbQnmuW4qGHVVfFL+o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P1OfuQORiCU4BEZFzbh9Hz8aJj2RllQjuZmiJ0jts4qJoOd5jDbdZryk2eU1FQ+hX4nW7VyrPYQrpFOIV03UG7vF3HcI4qbY1Hj4en4s0KGZnJHZmyUavAZfQpDLYX65JgU7vfnCqwGuEPe7KHR+vlEXl1gfWgS0gadLM712QH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=IgLSxXyp; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="IgLSxXyp" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C60C41A0EB2; Tue, 7 Jul 2026 14:00:18 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 97FEE60333; Tue, 7 Jul 2026 14:00:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D240A11BC2532; Tue, 7 Jul 2026 16:00:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1783432817; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=3MYQXM7UkANi2WT6aY2MDPikz9inXNl8D1Bb0zGbg7o=; b=IgLSxXypfN0MZ1rOo5iQyhIvtBVeXlLuS5UH4O3XEPh1p68PIZ04ZGCSy5QdcqZs6lKAXn 4VxKKSSOq6CwRimor6o1gmC9qjWDInEoTS7sZA7Q7CJgMdlChmeSFPiKfgu0s0l85B+nZG q89IW3Ct+6MxcgFTFMwiOPRCfWhmIuHbEkA7tAFN+fkKkHOE6H0cfyvlqAhB3G5/AbITsZ H+004Hnj5u3hmn5QQ5c5IdUiLVxVPoAALF10N2SEEJCk+y7xrKhrBHbcINJghsaUN9MCdJ eLQy054PtyzjzNHVW9bbk8ZnsZtpQ8r4n791uk1h04CNSEPqyO2WPtLnDpi2Hg== Message-ID: Date: Tue, 7 Jul 2026 16:00:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v13 09/10] net: ethtool: Introduce ethtool command to list ports To: Paolo Abeni , davem@davemloft.net, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Russell King , Heiner Kallweit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau , Frank Wunderlich References: <20260701110427.143945-1-maxime.chevallier@bootlin.com> <20260701110427.143945-10-maxime.chevallier@bootlin.com> <7f47104f-8333-4c10-aab6-90552daabefe@bootlin.com> From: Maxime Chevallier Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 7/7/26 15:46, Paolo Abeni wrote: > On 7/7/26 12:47 PM, Maxime Chevallier wrote: >> On 7/7/26 12:12, Paolo Abeni wrote: >>> >>> Both sashikos instances points to multiple races with dumps. I suspect >>> some explicit locking is required. >>> >>> https://sashiko.dev/#/patchset/20260701110427.143945-1-maxime.chevallier%40bootlin.com >>> https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260701110427.143945-1-maxime.chevallier%40bootlin.com >>> >>> I *think* this is hopefully the last pending issue. >> >> True indeed, the other issues are sashiko saying "what if we detach a PHY and attach it >> to another netdev", which can't happen :) I agree with some of the locking points that >> were found, I'll address that likely as a separate cleanup. > > I'm sorry, but I think it's better to address the above problems with > the main series to avoid a window of opportunity that could cause a lot > of quite randomic/drop by submissions to try to addresses them with a > lot of noise on the ML. I was thinking the opposite actually, send a cleanup series that gets the locking part correct before continuing with phy_port, as it seems for now the phy_port/topology code is avoiding races just because all the callpaths happen to be under rtnl(), but this isn't formalised properly with asserts and dedicated locks in the problematic parts of the code. I otherwise agree, let's not send buggy code to be fixed later and I definitely see what you mean about the random submissions to fix these. Maxime