* [PATCH] s390/dasd: add missing MODULE_DESCRIPTION() macros
@ 2024-06-16 2:19 Jeff Johnson
2024-06-29 3:24 ` Jeff Johnson
2024-07-01 10:57 ` Stefan Haberland
0 siblings, 2 replies; 6+ messages in thread
From: Jeff Johnson @ 2024-06-16 2:19 UTC (permalink / raw)
To: Stefan Haberland, Jan Hoeppner, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle
Cc: linux-s390, linux-kernel, kernel-janitors, Jeff Johnson
With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_diag_mod.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_eckd_mod.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_fba_mod.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
Corrections to these descriptions are welcomed. I'm not an expert in
this code so in most cases I've taken these descriptions directly from
code comments, Kconfig descriptions, or git logs. History has shown
that in some cases these are originally wrong due to cut-n-paste
errors, and in other cases the drivers have evolved such that the
original information is no longer accurate.
---
drivers/s390/block/dasd_diag.c | 1 +
drivers/s390/block/dasd_eckd.c | 1 +
drivers/s390/block/dasd_fba.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/s390/block/dasd_diag.c b/drivers/s390/block/dasd_diag.c
index ea4b1d01bb76..8245b742e4a2 100644
--- a/drivers/s390/block/dasd_diag.c
+++ b/drivers/s390/block/dasd_diag.c
@@ -29,6 +29,7 @@
#include "dasd_int.h"
#include "dasd_diag.h"
+MODULE_DESCRIPTION("S/390 Support for DIAG access to DASD Disks");
MODULE_LICENSE("GPL");
/* The maximum number of blocks per request (max_blocks) is dependent on the
diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index 2f16f543079b..f8113974cfba 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -44,6 +44,7 @@
/* 64k are 128 x 512 byte sectors */
#define DASD_RAW_SECTORS_PER_TRACK 128
+MODULE_DESCRIPTION("S/390 DASD ECKD Disks device driver");
MODULE_LICENSE("GPL");
static struct dasd_discipline dasd_eckd_discipline;
diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c
index 361e9bd75257..9ef7b168aba8 100644
--- a/drivers/s390/block/dasd_fba.c
+++ b/drivers/s390/block/dasd_fba.c
@@ -32,6 +32,7 @@
#define DASD_FBA_CCW_LOCATE 0x43
#define DASD_FBA_CCW_DEFINE_EXTENT 0x63
+MODULE_DESCRIPTION("S/390 DASD FBA Disks device driver");
MODULE_LICENSE("GPL");
static struct dasd_discipline dasd_fba_discipline;
---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240615-md-s390-drivers-s390-block-dasd-9a143c6ca093
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] s390/dasd: add missing MODULE_DESCRIPTION() macros
2024-06-16 2:19 [PATCH] s390/dasd: add missing MODULE_DESCRIPTION() macros Jeff Johnson
@ 2024-06-29 3:24 ` Jeff Johnson
2024-07-01 10:57 ` Stefan Haberland
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Johnson @ 2024-06-29 3:24 UTC (permalink / raw)
To: Stefan Haberland, Jan Hoeppner, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle
Cc: linux-s390, linux-kernel, kernel-janitors
On 6/15/2024 7:19 PM, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_diag_mod.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_eckd_mod.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_fba_mod.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> Corrections to these descriptions are welcomed. I'm not an expert in
> this code so in most cases I've taken these descriptions directly from
> code comments, Kconfig descriptions, or git logs. History has shown
> that in some cases these are originally wrong due to cut-n-paste
> errors, and in other cases the drivers have evolved such that the
> original information is no longer accurate.
> ---
> drivers/s390/block/dasd_diag.c | 1 +
> drivers/s390/block/dasd_eckd.c | 1 +
> drivers/s390/block/dasd_fba.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/s390/block/dasd_diag.c b/drivers/s390/block/dasd_diag.c
> index ea4b1d01bb76..8245b742e4a2 100644
> --- a/drivers/s390/block/dasd_diag.c
> +++ b/drivers/s390/block/dasd_diag.c
> @@ -29,6 +29,7 @@
> #include "dasd_int.h"
> #include "dasd_diag.h"
>
> +MODULE_DESCRIPTION("S/390 Support for DIAG access to DASD Disks");
> MODULE_LICENSE("GPL");
>
> /* The maximum number of blocks per request (max_blocks) is dependent on the
> diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
> index 2f16f543079b..f8113974cfba 100644
> --- a/drivers/s390/block/dasd_eckd.c
> +++ b/drivers/s390/block/dasd_eckd.c
> @@ -44,6 +44,7 @@
> /* 64k are 128 x 512 byte sectors */
> #define DASD_RAW_SECTORS_PER_TRACK 128
>
> +MODULE_DESCRIPTION("S/390 DASD ECKD Disks device driver");
> MODULE_LICENSE("GPL");
>
> static struct dasd_discipline dasd_eckd_discipline;
> diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c
> index 361e9bd75257..9ef7b168aba8 100644
> --- a/drivers/s390/block/dasd_fba.c
> +++ b/drivers/s390/block/dasd_fba.c
> @@ -32,6 +32,7 @@
> #define DASD_FBA_CCW_LOCATE 0x43
> #define DASD_FBA_CCW_DEFINE_EXTENT 0x63
>
> +MODULE_DESCRIPTION("S/390 DASD FBA Disks device driver");
> MODULE_LICENSE("GPL");
>
> static struct dasd_discipline dasd_fba_discipline;
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240615-md-s390-drivers-s390-block-dasd-9a143c6ca093
Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)
/jeff
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] s390/dasd: add missing MODULE_DESCRIPTION() macros
2024-06-16 2:19 [PATCH] s390/dasd: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-29 3:24 ` Jeff Johnson
@ 2024-07-01 10:57 ` Stefan Haberland
2024-07-14 16:58 ` Jeff Johnson
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Haberland @ 2024-07-01 10:57 UTC (permalink / raw)
To: Jeff Johnson, Jan Hoeppner, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle
Cc: linux-s390, linux-kernel, kernel-janitors
Am 16.06.24 um 04:19 schrieb Jeff Johnson:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_diag_mod.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_eckd_mod.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_fba_mod.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] s390/dasd: add missing MODULE_DESCRIPTION() macros
2024-07-01 10:57 ` Stefan Haberland
@ 2024-07-14 16:58 ` Jeff Johnson
2024-07-16 8:20 ` Stefan Haberland
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Johnson @ 2024-07-14 16:58 UTC (permalink / raw)
To: Stefan Haberland, Jan Hoeppner, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle
Cc: linux-s390, linux-kernel, kernel-janitors
On 7/1/24 03:57, Stefan Haberland wrote:
> Am 16.06.24 um 04:19 schrieb Jeff Johnson:
>> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>> drivers/s390/block/dasd_diag_mod.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>> drivers/s390/block/dasd_eckd_mod.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>> drivers/s390/block/dasd_fba_mod.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>
> Applied, thanks.
>
I still don't see this in linux-next. Does your tree feed into
linux-next, or will it go into Linus' tree during the merge window?
Hoping to have these warnings fixed tree-wide in 6.11
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] s390/dasd: add missing MODULE_DESCRIPTION() macros
2024-07-14 16:58 ` Jeff Johnson
@ 2024-07-16 8:20 ` Stefan Haberland
2024-07-16 14:33 ` Jeff Johnson
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Haberland @ 2024-07-16 8:20 UTC (permalink / raw)
To: Jeff Johnson, Jan Hoeppner, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle
Cc: linux-s390, linux-kernel, kernel-janitors
Am 14.07.24 um 18:58 schrieb Jeff Johnson:
> On 7/1/24 03:57, Stefan Haberland wrote:
>> Am 16.06.24 um 04:19 schrieb Jeff Johnson:
>>> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>>> drivers/s390/block/dasd_diag_mod.o
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>>> drivers/s390/block/dasd_eckd_mod.o
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>>> drivers/s390/block/dasd_fba_mod.o
>>>
>>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>>
>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>> ---
>>
>> Applied, thanks.
>>
>
> I still don't see this in linux-next. Does your tree feed into
> linux-next, or will it go into Linus' tree during the merge window?
>
> Hoping to have these warnings fixed tree-wide in 6.11
Sorry for the delay.
The DASD patches usually go upstream through the linux-block tree. I
have sent them yesterday and Jens already applied them.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] s390/dasd: add missing MODULE_DESCRIPTION() macros
2024-07-16 8:20 ` Stefan Haberland
@ 2024-07-16 14:33 ` Jeff Johnson
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Johnson @ 2024-07-16 14:33 UTC (permalink / raw)
To: Stefan Haberland, Jan Hoeppner, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle
Cc: linux-s390, linux-kernel, kernel-janitors
On 7/16/2024 1:20 AM, Stefan Haberland wrote:
> Am 14.07.24 um 18:58 schrieb Jeff Johnson:
>> On 7/1/24 03:57, Stefan Haberland wrote:
>>> Am 16.06.24 um 04:19 schrieb Jeff Johnson:
>>>> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>>>> drivers/s390/block/dasd_diag_mod.o
>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>>>> drivers/s390/block/dasd_eckd_mod.o
>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>>>> drivers/s390/block/dasd_fba_mod.o
>>>>
>>>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>>>
>>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>>> ---
>>>
>>> Applied, thanks.
>>>
>>
>> I still don't see this in linux-next. Does your tree feed into
>> linux-next, or will it go into Linus' tree during the merge window?
>>
>> Hoping to have these warnings fixed tree-wide in 6.11
>
> Sorry for the delay.
>
> The DASD patches usually go upstream through the linux-block tree. I
> have sent them yesterday and Jens already applied them.
>
thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-07-16 14:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-16 2:19 [PATCH] s390/dasd: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-29 3:24 ` Jeff Johnson
2024-07-01 10:57 ` Stefan Haberland
2024-07-14 16:58 ` Jeff Johnson
2024-07-16 8:20 ` Stefan Haberland
2024-07-16 14:33 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox