public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: SungHwan Jung <onenowy@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: acer-wmi: select ACPI_PLATFORM_PROFILE
Date: Thu, 30 Nov 2023 15:00:41 +0200 (EET)	[thread overview]
Message-ID: <c13f1666-33a1-2df2-649-c7d32e64c70@linux.intel.com> (raw)
In-Reply-To: <20231130124452.3460-1-onenowy@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

On Thu, 30 Nov 2023, SungHwan Jung wrote:

> select ACPI_PLATFORM_PROFILE to fix the dependency problem for acer-wmi
> to support platform profile.
> 
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311301842.ppdT4zWK-lkp@intel.com/
> 
> Signed-off-by: SungHwan Jung <onenowy@gmail.com>
> 
> ---
> I apologize that I missed dependency in kconfig.
> I have submitted a single patch because the series of patches were alreay
> merged to linux-next.
> Is this enough or should I re-submit the patch-series including this patch?
> (or modify this to apply before "platform/x86: acer-wmi: Add platform
> profile and modekey support for Predator PHN16-71" commit?)
> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 8e99a2f10147..81e6cd62a533 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -182,6 +182,7 @@ config ACER_WMI
>  	select INPUT_SPARSEKMAP
>  	select LEDS_CLASS
>  	select NEW_LEDS
> +	select ACPI_PLATFORM_PROFILE
>  	help
>  	  This is a driver for newer Acer (and Wistron) laptops. It adds
>  	  wireless radio and bluetooth control, and on some laptops,
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

I suspect Hans will just included that into the original patch so this 
patch will not appear in the history at all.

-- 
 i.

  reply	other threads:[~2023-11-30 13:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30 12:44 [PATCH] platform/x86: acer-wmi: select ACPI_PLATFORM_PROFILE SungHwan Jung
2023-11-30 13:00 ` Ilpo Järvinen [this message]
2023-12-02 11:32   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c13f1666-33a1-2df2-649-c7d32e64c70@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=onenowy@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox