[PATCH] platform/x86: acer-wmi: select ACPI_PLATFORM_PROFILE

[PATCH] platform/x86: acer-wmi: select ACPI_PLATFORM_PROFILE

[SungHwan Jung]

select ACPI_PLATFORM_PROFILE to fix the dependency problem for acer-wmi
to support platform profile.

| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311301842.ppdT4zWK-lkp@intel.com/

Signed-off-by: SungHwan Jung <onenowy@gmail.com>

---
I apologize that I missed dependency in kconfig.
I have submitted a single patch because the series of patches were alreay
merged to linux-next.
Is this enough or should I re-submit the patch-series including this patch?
(or modify this to apply before "platform/x86: acer-wmi: Add platform
profile and modekey support for Predator PHN16-71" commit?)
---
 drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 8e99a2f10147..81e6cd62a533 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -182,6 +182,7 @@ config ACER_WMI
 	select INPUT_SPARSEKMAP
 	select LEDS_CLASS
 	select NEW_LEDS
+	select ACPI_PLATFORM_PROFILE
 	help
 	  This is a driver for newer Acer (and Wistron) laptops. It adds
 	  wireless radio and bluetooth control, and on some laptops,
-- 
2.43.0

Re: [PATCH] platform/x86: acer-wmi: select ACPI_PLATFORM_PROFILE

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

On Thu, 30 Nov 2023, SungHwan Jung wrote:

> select ACPI_PLATFORM_PROFILE to fix the dependency problem for acer-wmi
> to support platform profile.
> 
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311301842.ppdT4zWK-lkp@intel.com/
> 
> Signed-off-by: SungHwan Jung <onenowy@gmail.com>
> 
> ---
> I apologize that I missed dependency in kconfig.
> I have submitted a single patch because the series of patches were alreay
> merged to linux-next.
> Is this enough or should I re-submit the patch-series including this patch?
> (or modify this to apply before "platform/x86: acer-wmi: Add platform
> profile and modekey support for Predator PHN16-71" commit?)
> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 8e99a2f10147..81e6cd62a533 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -182,6 +182,7 @@ config ACER_WMI
>  	select INPUT_SPARSEKMAP
>  	select LEDS_CLASS
>  	select NEW_LEDS
> +	select ACPI_PLATFORM_PROFILE
>  	help
>  	  This is a driver for newer Acer (and Wistron) laptops. It adds
>  	  wireless radio and bluetooth control, and on some laptops,
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

I suspect Hans will just included that into the original patch so this 
patch will not appear in the history at all.

-- 
 i.

Re: [PATCH] platform/x86: acer-wmi: select ACPI_PLATFORM_PROFILE

[Hans de Goede]

Hi,

On 11/30/23 14:00, Ilpo Järvinen wrote:
> On Thu, 30 Nov 2023, SungHwan Jung wrote:
> 
>> select ACPI_PLATFORM_PROFILE to fix the dependency problem for acer-wmi
>> to support platform profile.
>>
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202311301842.ppdT4zWK-lkp@intel.com/
>>
>> Signed-off-by: SungHwan Jung <onenowy@gmail.com>
>>
>> ---
>> I apologize that I missed dependency in kconfig.
>> I have submitted a single patch because the series of patches were alreay
>> merged to linux-next.
>> Is this enough or should I re-submit the patch-series including this patch?
>> (or modify this to apply before "platform/x86: acer-wmi: Add platform
>> profile and modekey support for Predator PHN16-71" commit?)
>> ---
>>  drivers/platform/x86/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>> index 8e99a2f10147..81e6cd62a533 100644
>> --- a/drivers/platform/x86/Kconfig
>> +++ b/drivers/platform/x86/Kconfig
>> @@ -182,6 +182,7 @@ config ACER_WMI
>>  	select INPUT_SPARSEKMAP
>>  	select LEDS_CLASS
>>  	select NEW_LEDS
>> +	select ACPI_PLATFORM_PROFILE
>>  	help
>>  	  This is a driver for newer Acer (and Wistron) laptops. It adds
>>  	  wireless radio and bluetooth control, and on some laptops,
>>
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 
> I suspect Hans will just included that into the original patch so this 
> patch will not appear in the history at all.

Right.

Thank you both for the patch and the review.

I have squashed this change into the original patch introducing
the platform_profile support.

You can find the new version in my pdx86/review-hans branch and the
pdx86/for-next branch now.

Regards,

Hans