Re: [PATCH v2] mtd: spi-nor: winbond: Add support for W77Q51NW

[Tudor Ambarus <tudor.ambarus@linaro.org>]

On 7/22/25 9:43 AM, Michael Walle wrote:
> Hi Marek,
> 
>> --- a/drivers/mtd/spi-nor/winbond.c
>> +++ b/drivers/mtd/spi-nor/winbond.c
>> @@ -343,6 +343,10 @@ static const struct flash_info winbond_nor_parts[] = {
>>          .id = SNOR_ID(0xef, 0x80, 0x20),
>>          .name = "w25q512nwm",
>>          .otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
>> +    }, {
>> +        /* W77Q51NW */
>> +        .id = SNOR_ID(0xef, 0x8a, 0x1a),
>> +        .otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
> 
> Did you also test the OTP read and write? I'd guess so, because otherwise

Any of you interested in adding testing requirements and examples for otp?

> you wouldn't need that entry at all, right? Or is it because of the
> winbond_nor_late_init() which will be called as a manufacturer fixup?

M,

the overwrite of set_4byte_addr_mode in winbond_nor_late_init() seems a
little trashy, we assume that winbond will always use
spi_nor_set_4byte_addr_mode_en4b_ex4b(), apart of the extra ops that we're
doing there. Aren't we better without this generalization?

> In that case we could do the same as in commit afe1ea1344bb ("mtd: spi-nor:
> add support for Macronix Octal flash").
> 
> -michael