From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 769A33E717B for ; Tue, 5 May 2026 18:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778004937; cv=none; b=Q5jqHhbqDbe3WBa5rakh2JAHbxnlBCyFGaNa0q73y119BuT/vq9oPJHS0EheVks83VAuhLYfn/CquKTcjoilVVP5Z0YuR48vWbfa30ZkyhoaGtiROBIu2D8RKLuNH4yOQ5xuSuaJIckzXgsnRcpqlfSEY8GKsdEaq7te94COP4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778004937; c=relaxed/simple; bh=Fvrf56zIpDoyp0ymI4zysnOLw48mM1lICxB/cw9uTsY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q8FlFegPKlVjzA4wkqb0QO1Uzm0OH/alf8w0s/n6mthTyfx9mYZregLkHMHjrq/0SfU3I0HmdMxt+rDY8LmUBoUoPHEji+fUIyCy7RIS/F40EXIzhlzzfSUSLQAAxAWwiJ0xrNFhJpszOHnCFxZGTNS9QVGjj2ZgQW9lYrz0U0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cHkFC6KO; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cHkFC6KO" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7de44ed7a11so4520616a34.1 for ; Tue, 05 May 2026 11:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1778004934; x=1778609734; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ETXFyGjM6fzwZQL1DErnQaqDelKDbjTQSxjQFgvXNiU=; b=cHkFC6KOQNE2U0rcrN3LfSB4xlQ2cV3YlQQHdTlcBZdqR51GUcGqoUdBa4NHJgSgJ4 Eu9MOgOifefKR6kfyeF8vxg4kB74RsbRC6VYGUCkdHyM3FR1TEXrp31x+vZr7E4gE1UF 8VyK2+gtkbj5zEQ5FmukOnWYYoymV2Lv6mbd4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778004934; x=1778609734; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ETXFyGjM6fzwZQL1DErnQaqDelKDbjTQSxjQFgvXNiU=; b=ST7p/VyTVJbfVQMBHbw7U85gJfZFaI/mFXV9DVRoa/DFZ5/E/WmMuzOuq62Ir3GEJV X9j8akqVlRrPZ2nXAXJYs1qXOEQBXZrbyK7a6uPoHQDPodjjJb+Su8ts9dawgfC7Lwir bHIxyRGN+p9VJdaMlVDw44tgGD4TrCLTaR6/MveqQMFGah99y/5MAOwk5cH58HnsLEK7 DkHbSRGZ3AybsLMZR+oi/pZ6JLQ1Mg2pwt6fQoj1/iUcKY5E0nyyfw3uUrCQAzw4JyTk T8AeD6i4TzAg1Lwceo30zUnqXFgZ7raUn7r/VETvsUJrCQ5S1FHEbDdmOSXm2yusXaC+ oPSg== X-Forwarded-Encrypted: i=1; AFNElJ+O4oN3t31xVRnC03+k2hV3wO82FM7w/vlaXOcEJ7epISB1fkyf6Gmvd90BejcUNPtXbiLI5Xt7boBWTVE=@vger.kernel.org X-Gm-Message-State: AOJu0YyvhJQXUaRBlpZ8POSkb9Or6XhsZONokAFQaNBcQBz9kePkmNVm I93v70eZ2wriWZbgtDZMsuxo1bv8BXavqRhS7fHtl2dR6p3o+0eTt6ZTA3VDEIARpWE= X-Gm-Gg: AeBDietBmLXSwfFn5cKufSNL1mzw2/ZgHhvH+8rv93ZY+Zx+u55vn85axxiP4/g1I5G aoK68koUzl3wYLFoL3UcWGMOf6VgExAgwVzmS+9EJOyXKxrnComcIMZ3uR2pZLGq0uECa4Ilnhu tdE6A62y8WWRuFvEL9YcO87/AwAzzOeCbfpDNspMNO1WBC/et6Ui9V0q4Noy7Yubn5bWkcXmv1R LZ3oItPxYXK+MMRPXp5IU2OSSB5NBctLa+piYwBa2Ro+NvXyQlTV4ZTm1kn8fMmaCwftlzc0D6Y HdS0VeQ7zDk+QdGIv57UQSYqZVp39mKCrxtQhLXoYaGXU4w7KipEde7qkg7FtyHEDlaMm1e6ApY OCDxJqLiqlT5FcwPRxo+Qge5Isp6nLV2cWZIMVOD13DQFH93nu+FhbnLwYY2pXWRZiSnf3HpDG1 n9BHi+WAvfwGW55lyQ1lmtfgxdL+h+ayLGK015n5ekOpy+NzSTMJKz X-Received: by 2002:a05:6830:4123:b0:7dc:1615:7b52 with SMTP id 46e09a7af769-7dee148195fmr9169749a34.26.1778004934454; Tue, 05 May 2026 11:15:34 -0700 (PDT) Received: from [192.168.1.14] ([38.15.57.99]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7deca7e475esm10282500a34.7.2026.05.05.11.15.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 11:15:33 -0700 (PDT) Message-ID: Date: Tue, 5 May 2026 12:15:32 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] usbip: vhci_hcd: fix NULL deref in status_show_vhci To: Adrian Wowk , valentina.manea.m@gmail.com, shuah@kernel.org Cc: i@zenithal.me, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20260414010050.158064-1-dev@adrianwowk.com> <20260414010050.158064-2-dev@adrianwowk.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260414010050.158064-2-dev@adrianwowk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/13/26 19:00, Adrian Wowk wrote: > platform_get_drvdata() can return NULL if a VHCI host controller's > probe failed (e.g. due to USB bus number exhaustion). status_show_vhci() > checked for a NULL pdev but not for a NULL hcd returned by > platform_get_drvdata(). Passing NULL to hcd_to_vhci_hcd() does not > return NULL - it returns a pointer offset of 0x260, causing a NULL > pointer dereference when that value is subsequently dereferenced. > > Add a NULL check on hcd before calling hcd_to_vhci_hcd(). Move > status_show_not_ready() above status_show_vhci() to make it callable > from the new error path without a forward declaration. > > Signed-off-by: Adrian Wowk > --- > drivers/usb/usbip/vhci_sysfs.c | 52 +++++++++++++++++++--------------- > 1 file changed, 29 insertions(+), 23 deletions(-) > Looks good to me. Reviewed-by: Shuah Khan Greg, Please pick this up. thanks, -- Shuah