public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Pedro Henrique Kopper <pedro.kopper@canonical.com>,
	rafael@kernel.org,  lenb@kernel.org, viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: intel_pstate: Update Balance performance EPP for Emerald Rapids
Date: Thu, 01 Aug 2024 12:42:21 -0700	[thread overview]
Message-ID: <c15a8a105308262856ee14bab558d34df8bdf92a.camel@linux.intel.com> (raw)
In-Reply-To: <Zqu6zjVMoiXwROBI@capivara>

On Thu, 2024-08-01 at 13:41 -0300, Pedro Henrique Kopper wrote:
> On Intel Emerald Rapids machines, we ship the Energy Performance
> Preference
> (EPP) default for balance_performance as 128. However, during an
> internal
> investigation together with Intel, we have determined that 32 is a
> more
> suitable value. This leads to significant improvements in both
> performance
> and energy:
> 
> POV-Ray: 32% faster | 12% less energy
> OpenSSL: 12% faster | energy within 1%
> Build Linux Kernel: 29% faster | 18% less energy
> 
> Therefore, we should move the default EPP for balance_performance to
> 32.
> This is in line with what has already been done for Sapphire Rapids.
> 
> Signed-off-by: Pedro Henrique Kopper <pedro.kopper@canonical.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/cpufreq/intel_pstate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 392a8000b238..c0278d023cfc 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -3405,6 +3405,7 @@ static const struct x86_cpu_id
> intel_epp_default[] = {
>  	 */
>  	X86_MATCH_VFM(INTEL_ALDERLAKE_L,
> HWP_SET_DEF_BALANCE_PERF_EPP(102)),
>  	X86_MATCH_VFM(INTEL_SAPPHIRERAPIDS_X,
> HWP_SET_DEF_BALANCE_PERF_EPP(32)),
> +	X86_MATCH_VFM(INTEL_EMERALDRAPIDS_X,
> HWP_SET_DEF_BALANCE_PERF_EPP(32)),
>  	X86_MATCH_VFM(INTEL_METEORLAKE_L,
> HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE,
>  		      179, 64, 16)),
>  	X86_MATCH_VFM(INTEL_ARROWLAKE,
> HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE,


  reply	other threads:[~2024-08-01 19:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01 16:41 [PATCH] cpufreq: intel_pstate: Update Balance performance EPP for Emerald Rapids Pedro Henrique Kopper
2024-08-01 19:42 ` srinivas pandruvada [this message]
2024-08-02 12:43   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c15a8a105308262856ee14bab558d34df8bdf92a.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pedro.kopper@canonical.com \
    --cc=rafael@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox