From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB61D1E5B70 for ; Mon, 14 Apr 2025 20:45:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744663509; cv=none; b=G1GK3ujCSih7e02oKTRCuZ6dj33iXnpnlSjjx24d/HatKKVKTpB6lVOBtbne2PEYgQc5cHf+ZNWqevL1YXI1cBN0HkdAmCP/AATL1BKufZ2ei0JyF2RO5kq6oWbCJAzC3Keb7uwIumEBQ+f5AJEAn4Fkbcm9DxLpjK+4T92qudA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744663509; c=relaxed/simple; bh=zWsdiw+TnJkpRWJoGIEhDbM9jVc3PLjahi1iBg9BPKo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iM+UjD9NrqnGxK9YEz468daLsfeeNvMX2kBUNvNJQ92gjODn/B/lBRlqXQrFeAIOy6V3ShbbxspvNLQnHdYqpMAD1EDSrITaUtjyfUY8yvVZ4pQ7ncafYT6sKfY/OZ/067wkWxNQjcO9tCYmfcoLdlXgadUlsAhWQLFROjytEsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KBxCIJWE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KBxCIJWE" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53EKeEgA016124 for ; Mon, 14 Apr 2025 20:45:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8GpvC2xMf26mIWpkQqHlnNwAhWALEdfs8GLwqb4OfI8=; b=KBxCIJWEzDpTzj4J XjyWl8fUJsYhEsbotApe19vWNG1m0Yvs7M1ROZt8nJk3KhDcHY42mF/oxvQ1UPZ9 YqAZf1nQ3GWl0r26lWtz8/zsBZqO7tSbFiRyV5KHmpdZOXJGzNkGfypP4TA2Hehy dND01cfjyEO5NGuwOieSKvNsS1KpqPE/ZuBpZiRTXKquifUmwGsMUheDJ8wyc8g0 4g9BEWhO4vSGavr7e/V24EUFWGPKyJSGiclYyx1iUY4aIfC0MNUnRjEHm70jFM8L EjpHugjS/PPy3aPlKeHuaEW+RLdkCOVYAOvZ+y5KTAMCOwgQ5HFjYQwNJjIKwn2m qzQqFw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45ygj95rbv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 14 Apr 2025 20:45:06 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5560e0893so35992585a.1 for ; Mon, 14 Apr 2025 13:45:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744663506; x=1745268306; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8GpvC2xMf26mIWpkQqHlnNwAhWALEdfs8GLwqb4OfI8=; b=ntkBkvcOTWRRvtqRLIOefJZmkmCP1aSvQtourwBwfunWcqc4joznLdeWZJ3uUlne64 Dz4pGRqh8A9YQ2thVH6CucJWDk3Thw1Z+NnRcZ9PBfP5j8CgtL9xgj09PYO9CwtFUlun O//BAse/9oz4/QR3x/ZIveSnp8xGKclp/CM5o8bKdPOuzVtOkRuTa5417yhHUS8KdmLw SdQ52yy81mU0CUNEOVWRjHxvrpeBcOQgUQqRkeAxhf+lanrqwi7DVi9eAyJffhN+8CPS FnW823FhVlooTHVnpRWL1mBa1fN5oKe8u9t4pWAIuCxosTLz4LeqvjeQ56RncQjF3h6K FbmQ== X-Forwarded-Encrypted: i=1; AJvYcCUDSA5Q1ZUZpjcbUS9Cb/Pn5Kd3Trc2rmVEoOsCGo7sY9D6DbINRQIEaAD5/igpnFw9Wk4/8OhLIOSThOk=@vger.kernel.org X-Gm-Message-State: AOJu0YxE3pFhOrjSQoO5rsTc9642NHinyYX6ttXRxN5CYRfq8rG3YknY OD6X1/6tKcDH5/TinMojlMNYGBeVm0vRd4r1n2P11iGK9yyOe7j8fpHEyOcwo+mT181Pz4vsBxH Albigr4ZOzd8NJxdvRG4CVQUVz4MjtjM1t0dwkhZY9hHitVgv7n+FSHMZMiKFlgA= X-Gm-Gg: ASbGncs+rlgi8jDz/x+QDvmvCBAmu71pkmDUoE8yCHYu/iQkaXyt7waV9Riv8xvcM0q R6dBYE+MrZRvneYgzKTNjO6qVnuyj/lbHOa7lHGHrQP/xvtv8EBky6VyNvn+vdsneDo29/yP/rD lY40nlubzX3A95HpWvW5/PHsPl/Cgdh0pGd4Vv5TJXSTsmHxo/9RwiWY6U4y2evgTU6p3SaFPCp L64+4eoyp4kWKn4ZwInZlhIj5qek+aUcweNw971DKRCsERwx/uz+tT+Z4KjMYCph9uiuFasSUiG 2Z9AIRaR9vBIrwQ3PxR2UDdoRa2T8Ob1k9DIAwZUuRTuaGUYZUFP7g4RloOHaHz2kw== X-Received: by 2002:a05:620a:c4e:b0:7c0:bb63:5375 with SMTP id af79cd13be357-7c7af0d639amr601361485a.4.1744663505688; Mon, 14 Apr 2025 13:45:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLBb2WpVtzoAT+y2FmV5MGo40yUFAbGagDmJALFL0LsA+GecCl49y7VoJexczSZFb7o/nmpw== X-Received: by 2002:a05:620a:c4e:b0:7c0:bb63:5375 with SMTP id af79cd13be357-7c7af0d639amr601360185a.4.1744663505264; Mon, 14 Apr 2025 13:45:05 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ce7fdcsm982525066b.176.2025.04.14.13.45.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 13:45:04 -0700 (PDT) Message-ID: Date: Mon, 14 Apr 2025 22:45:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/6] arm64: dts: qcom: Add Xiaomi Redmi 3S To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , =?UTF-8?Q?Otto_Pfl=C3=BCger?= , Linus Walleij , Lee Jones , Srinivas Kandagatla , Joerg Roedel , Will Deacon , Robin Murphy , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org References: <20250315-msm8937-v4-0-1f132e870a49@mainlining.org> <20250315-msm8937-v4-6-1f132e870a49@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250315-msm8937-v4-6-1f132e870a49@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: FFdNko307pkGZs8ZE0tIhjpQlLVNoiNh X-Authority-Analysis: v=2.4 cv=PruTbxM3 c=1 sm=1 tr=0 ts=67fd73d2 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=OuZLqq7tAAAA:8 a=JKK38O5rW3uoAxCGYa0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-GUID: FFdNko307pkGZs8ZE0tIhjpQlLVNoiNh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-14_07,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 spamscore=0 mlxscore=0 mlxlogscore=841 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504140151 On 3/15/25 3:57 PM, Barnabás Czémán wrote: > Add initial support for Xiaomi Redmi 3S (land). > > Signed-off-by: Barnabás Czémán > --- [...] > + headphones_switch: audio-switch { > + compatible = "simple-audio-amplifier"; > + enable-gpios = <&tlmm 129 GPIO_ACTIVE_HIGH>; > + sound-name-prefix = "Headphones Switch"; > + pinctrl-0 = <&headphones_switch_default>; > + pinctrl-names = "default"; > + }; We've had a similar change lately https://lore.kernel.org/linux-arm-msm/20250327100633.11530-1-srinivas.kandagatla@linaro.org/ I think this could be some sort of a drivers/mux/... [...] > +&pm8937_resin { > + linux,code = ; > + status = "okay"; > +}; Please also unify the style such that there's a newline before status Looks good otherwise Konrad