From: Andrew Lunn <andrew@lunn.ch>
To: Iulian Gilca <igilca1980@gmail.com>
Cc: igilca@outlook.com, Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: net: Add option for random mac address
Date: Fri, 11 Oct 2024 01:00:54 +0200 [thread overview]
Message-ID: <c176cabc-36fc-4c87-bfc3-403feceff41f@lunn.ch> (raw)
In-Reply-To: <20241010215417.332801-1-igilca1980@gmail.com>
On Thu, Oct 10, 2024 at 05:54:17PM -0400, Iulian Gilca wrote:
> Embedded devices that don't have a fixed mac address may want
> to use this property. For example dsa switch ports may use this property in
> order avoid setting this from user space. Sometimes, in case of DSA switch
> ports is desirable to use a random mac address rather than using the
> conduit interface mac address.
>
> example device tree config :
>
> ....
> netswitch: swdev@5f {
> compatible = "microchip,ksz9897";
> ...
> ports {
> port@0 {
> reg = <0>;
> label = "eth0";
> random-address;
> }
> ...
> }
> }
>
> ...
>
> This way the switch ports that have the "random-address" property
> will use a random mac address rather than the conduit mac address.
>
> PS. Sorry for the previous malformed patch
In addition to Russells emai:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
and it is much better to answer questions asked than post yet another
patch. Yes, the commit message is better, but it still does not fully
explain 'Why?' and convince us this is the correct solution to your
problem. What _is_ the problem you are trying to solve?
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2024-10-10 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 19:05 [PATCH] of: net: Add option for random mac address Iulian Gilca
2024-10-10 19:53 ` Andrew Lunn
2024-10-10 20:29 ` [PATCH v2] User random address if dt sets so Iulian Gilca
2024-10-10 20:59 ` Andrew Lunn
2024-10-10 21:54 ` [PATCH] of: net: Add option for random mac address Iulian Gilca
2024-10-10 22:54 ` Russell King (Oracle)
2024-10-10 23:00 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c176cabc-36fc-4c87-bfc3-403feceff41f@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=igilca1980@gmail.com \
--cc=igilca@outlook.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox