From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steve Caldwell <Steve.Caldwell@microchip.com>
Subject: Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl()
Date: Thu, 28 Jul 2016 18:00:24 +0200 [thread overview]
Message-ID: <c178cb06-a4b2-0a43-1de1-61bd67816deb@users.sourceforge.net> (raw)
In-Reply-To: <trinity-308db848-f204-4ebe-9336-484347ffbf37-1469706334519@3capp-gmx-bs72>
> Which circumstances do "not any sense at all" imply?
Should the expression 'strlen("RSSI")' be passed for the parameter 'length' instead?
> I suggest to fix this since it is indeed a bug,
We can agree that this function implementation was broken for a while there.
> instead of doing "micro optimizations" - which is the last thing that code in the staging area
> needs (as IIRC you have already been told by others, including the staging maintainer).
The acceptance might grow a bit more for such software fine-tuning
(like refactoring around variable usage).
Regards,
Markus
prev parent reply other threads:[~2016-07-28 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 19:17 [PATCH 3/3] staging: wilc1000: Reduce scope for a few variables in mac_ioctl() Lino Sanfilippo
2016-07-25 19:32 ` walter harms
2016-07-26 6:25 ` SF Markus Elfring
2016-07-28 11:45 ` Aw: " Lino Sanfilippo
2016-07-28 16:00 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c178cb06-a4b2-0a43-1de1-61bd67816deb@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=LinoSanfilippo@gmx.de \
--cc=Steve.Caldwell@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox