From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1363E5A35; Fri, 3 Jul 2026 14:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783090073; cv=none; b=KpaMFfCEq5UOg/dkkPKTPrup2EolIijShGWoxCk5UCAEFKcZ2kHYGb107/RPk4MHgi0VHt06q7xJaNR52YrVGTOP/iH3LacEqdAZzYBEPTQtnJ7irm3ZPmEQ1kFddbChsSXPgcKs5G7qAvJVM6dheJCrCGXXtUVPqHjl7+91ySM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783090073; c=relaxed/simple; bh=OrJl1yZsPhYap+V1mJq0k5wBzE2/zxAvLqCIXv55nyQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dau3rIS4jtNBbaRKH2I4JhU4U4ohqTyBvi6gkwYqMnFzADPP/giguG3HnQBZCeySHPHbyJN6Gcn/7hntV5wARtuBxWshvWqNe/3HgCBG9LECPh/aJMR6w+HuodexJmZ9BGCF8cKGVGUmVkE6NqFB5t7w6jzDEIQFpSY90ygxIk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BOr9JdBK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BOr9JdBK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E96611F000E9; Fri, 3 Jul 2026 14:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783090072; bh=++HtMmCEBA7w8FrNqOslZOYs3zVbl6ItX4gBTPB45Mc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=BOr9JdBKeACLOBw37ysPcXjcBg+8Kmutrr0FxkkgmCpFkxIeV2lj1YM5c9KRrytr2 vCrlJyE7eRNltweKDIre6Lo+H3OTQTD11iYUhsKeihD8Wgkm7nZSJnx6LjpXUykQQj E8iEVSSpMez1/VyX/SDSMr6pYhsFdXKCcxET3fnXyYOhdfUUaHiDdSQ5q9LYyEGVZ0 AILEhHNg6axhuUbi5YoXWUnku4g7bVZPhlOabMhcsEYHschJ6VYT4oX+u8WO19W6rP +eJx3tGOe1vmJwjWao8awWcxIGvwXvLUgu2KkROVGQxg0F/fbxqSiFUku0TStsPWGt ZiKEH7T4AsjYw== Message-ID: Date: Fri, 3 Jul 2026 16:47:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge creation To: Ananthu C V Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mathieu Poirier , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20260703-glymur-soccp-v4-0-b706c4c9b3e2@oss.qualcomm.com> <20260703-glymur-soccp-v4-1-b706c4c9b3e2@oss.qualcomm.com> <579360fe-9276-4d5b-9da3-e479ab8e5e37@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/07/2026 16:35, Ananthu C V wrote: > Hi Krzysztof, > > On Fri, Jul 03, 2026 at 02:44:41PM +0200, Krzysztof Kozlowski wrote: >> On 03/07/2026 14:31, Ananthu C V wrote: >>> Most Qualcomm platforms feature Gunyah hypervisor, which typically >>> handles Stage 2 IOMMU configuration. Additionally, SHM bridge setup >>> is required to enable memory protection for both remoteproc metadata >>> and its memory regions. When the aforementioned hypervisor is absent, >>> the operating system must perform these configurations instead. We've >>> been relying on the iommu property being present for this, but for >>> remoteprocs that are already running like SoCCP the mappings are already >>> in place, and any attempt to recreate them while active would lead to smmu >>> faults and a non-functional remoteproc. Fix this by adding a needs_tzmem >>> flag which ensures tzmem and SHM bridge setup is performed independent to >>> the iommu property being present. >> >> Looks awfully like LLM written and considering obvious problem, this >> feels vibe coded. >> >> According to current docs YOU SHOULD add vibe-coding tag to the commit >> when doing that. > > Part of the commit message is based on 5c720260e840, and the rest is all written > and readjusted manually. Every single line of change in the code also is fully > handwritten - well, typed - by me. I don't know where the feeling came from, but > please be relieved to know that there has been no involvement of AI here. > >>> static const struct of_device_id qcom_pas_of_match[] = { >>> { .compatible = "qcom,eliza-adsp-pas", .data = &sm8550_adsp_resource }, >>> + { .compatible = "qcom,glymur-soccp-pas", .data = &glymur_soccp_resource }, >> >> Please run scripts/checkpatch.pl on the patches and fix reported >> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the >> patches and (probably) fix more warnings. Some warnings can be ignored, >> especially from --strict run, but the code here looks like it needs a >> fix. Feel free to get in touch if the warning is not clear. > > I ran checkpatch well over twenty times before posting the series, and I did > it a few more times after seeing your reply. I did not run into any problems, > and as such I cannot understand the problem here. > > I could not paste this into an external pastebin from my work pc due to policy > reasons, so please forgive me for sharing this extended paste here: There is no qcom,glymur-soccp-pas documented here. It was in separate patchset which is already bringing confusion - the documentation goes with the user. If you keep things separate, expect such comments and no reviews. Best regards, Krzysztof