Re: [PATCH v1 1/7] dt-bindings: i2c: qcom,i2c-geni: Document DT properties for QUP firmware loading

Dmitry Baryshkov
2024-12-04T22:36:19Z

On Wed, Dec 04, 2024 at 08:33:20PM +0530, Viken Dadhaniya wrote:
> Document the 'qcom,load-firmware' and 'qcom,xfer-mode' properties to
> support SE(Serial Engine) firmware loading from the protocol driver and to
> select the data transfer mode, either GPI DMA (Generic Packet Interface)
> or non-GPI mode (PIO/CPU DMA).
>
> I2C controller can operate in one of two modes based on the
> 'qcom,xfer-mode' property, and the firmware is loaded accordingly.
>
> Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> ---
> .../devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> index 9f66a3bb1f80..a26f34fce1bb 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> @@ -66,6 +66,15 @@ properties:
> required-opps:
> maxItems: 1
>
> + qcom,load-firmware:
> + type: boolean
> + description: Optional property to load SE (serial engine) Firmware from protocol driver.
> +
> + qcom,xfer-mode:
> + description: Value 1,2 and 3 represents FIFO, CPU DMA and GSI DMA mode respectively.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [1, 2, 3]
> +
> required:
> - compatible
> - interrupts
> @@ -142,5 +151,7 @@ examples:
> interconnect-names = "qup-core", "qup-config", "qup-memory";
> power-domains = <&rpmhpd SC7180_CX>;
> required-opps = <&rpmhpd_opp_low_svs>;
> + qcom,load-firmware;

please use instead:
firmware-name = "qcom/sc7180/qupv3.elf"

> + qcom,xfer-mode = <1>;
> };
> ...
> --
> 2.34.1
>

--
With best wishes
Dmitry