The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Luke D. Jones" <luke@ljones.dev>, linux-kernel@vger.kernel.org
Cc: platform-driver-x86@vger.kernel.org,
	ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com,
	corentin.chary@gmail.com, superm1@kernel.org
Subject: Re: [PATCH 0/3] platfom/x86: asus-wmi: revert ROG Ally quirks
Date: Thu, 26 Sep 2024 08:36:32 -0500	[thread overview]
Message-ID: <c19f3530-a065-461f-a5bf-ccc3988cf24c@amd.com> (raw)
In-Reply-To: <20240926095344.1291013-1-luke@ljones.dev>

On 9/26/2024 04:53, Luke D. Jones wrote:
> The ASUS ROG Ally (and Ally X) quirks that I added over the last year
> are not required. I worked with ASUS to pinpoint the exact cause of
> the original issue (MCU USB dev missing every second resume) and the
> result is a new MCU firmware which will be released on approx 16/10/24.
> 
> All users should update to MCU FW as soon as released to:
> - Ally 1: v319
> - Ally X: v313
> 
> Luke D. Jones (3):
>    Revert "platform/x86: asus-wmi: ROG Ally increase wait time, allow MCU
>      powersave"
>    Revert "platform/x86: asus-wmi: disable USB0 hub on ROG Ally before
>      suspend"
>    platfom/x86: asus-wmi: cleanup after Ally quirk reverts
> 
>   drivers/platform/x86/asus-wmi.c | 39 +--------------------------------
>   1 file changed, 1 insertion(+), 38 deletions(-)
> 

This series looks good to me, but I would suggest that you also in the 
appropriate HID driver that communicates with the MCU to show a warning 
or notice if the version is below the required version.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

  parent reply	other threads:[~2024-09-26 13:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-26  9:53 [PATCH 0/3] platfom/x86: asus-wmi: revert ROG Ally quirks Luke D. Jones
2024-09-26  9:53 ` [PATCH 1/3] Revert "platform/x86: asus-wmi: ROG Ally increase wait time, allow MCU powersave" Luke D. Jones
2024-09-26  9:53 ` [PATCH 2/3] Revert "platform/x86: asus-wmi: disable USB0 hub on ROG Ally before suspend" Luke D. Jones
2024-09-26  9:53 ` [PATCH 3/3] platfom/x86: asus-wmi: cleanup after Ally quirk reverts Luke D. Jones
2024-09-28 20:56   ` kernel test robot
2024-09-26 13:36 ` Mario Limonciello [this message]
2024-10-02  8:12   ` [PATCH 0/3] platfom/x86: asus-wmi: revert ROG Ally quirks Luke Jones
2024-10-05 14:37 ` Hans de Goede
2024-10-05 19:48   ` Luke Jones
2024-10-05 21:59     ` Hans de Goede
2024-10-08  0:03     ` Luke Jones
2024-10-08  1:53       ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c19f3530-a065-461f-a5bf-ccc3988cf24c@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=corentin.chary@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=superm1@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox